* [PATCH] wl12xx: Correctly set up protection if non-GF STAs are present
@ 2011-03-02 9:46 Helmut Schaa
2011-03-03 15:45 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Helmut Schaa @ 2011-03-02 9:46 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, coelho, Helmut Schaa
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
I don't know wl12xx as all and I don't have such a device. This is based on the
assumption that setting acx->gf_protection to 1 enables protection for GF
transmissions. So, this is only compile tested.
It just popped up while discussing HT operation mode handling in hostapd.
Please review.
Thanks,
Helmut
drivers/net/wireless/wl12xx/acx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/acx.c b/drivers/net/wireless/wl12xx/acx.c
index 3badc6b..a3db755 100644
--- a/drivers/net/wireless/wl12xx/acx.c
+++ b/drivers/net/wireless/wl12xx/acx.c
@@ -1361,7 +1361,8 @@ int wl1271_acx_set_ht_information(struct wl1271 *wl,
acx->ht_protection =
(u8)(ht_operation_mode & IEEE80211_HT_OP_MODE_PROTECTION);
acx->rifs_mode = 0;
- acx->gf_protection = 0;
+ acx->gf_protection =
+ !!(ht_operation_mode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT);
acx->ht_tx_burst_limit = 0;
acx->dual_cts_protection = 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wl12xx: Correctly set up protection if non-GF STAs are present
2011-03-02 9:46 [PATCH] wl12xx: Correctly set up protection if non-GF STAs are present Helmut Schaa
@ 2011-03-03 15:45 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2011-03-03 15:45 UTC (permalink / raw)
To: Helmut Schaa; +Cc: linville, linux-wireless
On Wed, 2011-03-02 at 10:46 +0100, Helmut Schaa wrote:
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
This is good, thanks Helmut! We had some problems with earlier versions
of our firmware where this was apparently not implemented, that's why we
were setting it always to 0.
I added a description to your commit, hope you don't mind.
Applied!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-03 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-02 9:46 [PATCH] wl12xx: Correctly set up protection if non-GF STAs are present Helmut Schaa
2011-03-03 15:45 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox