* [PATCH] wl12xx: configure channel/band while FW is off
@ 2011-03-22 8:07 Arik Nemtsov
2011-03-22 9:59 ` Arik Nemtsov
2011-04-01 7:50 ` Luciano Coelho
0 siblings, 2 replies; 3+ messages in thread
From: Arik Nemtsov @ 2011-03-22 8:07 UTC (permalink / raw)
To: linux-wireless; +Cc: Luciano Coelho, Arik Nemtsov
Initialize the channel and band from mac80211 conf even when the FW is
not yet loaded. This mitigates a bug in AP-mode where the channel was
never changed from its initial setting after FW boot and was therefore
never configured to FW.
Reported-by: Alexander Boukaty <alexanderb@ti.com>
Signed-off-by: Arik Nemtsov <arik@wizery.com>
---
drivers/net/wireless/wl12xx/main.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 85cb4da..c262e60 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -1707,7 +1707,12 @@ static int wl1271_op_config(struct ieee80211_hw *hw, u32 changed)
mutex_lock(&wl->mutex);
if (unlikely(wl->state == WL1271_STATE_OFF)) {
- ret = -EAGAIN;
+ /* we support configuring the channel and band while off */
+ if ((changed & IEEE80211_CONF_CHANGE_CHANNEL)) {
+ wl->band = conf->channel->band;
+ wl->channel = channel;
+ }
+
goto out;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] wl12xx: configure channel/band while FW is off
2011-03-22 8:07 [PATCH] wl12xx: configure channel/band while FW is off Arik Nemtsov
@ 2011-03-22 9:59 ` Arik Nemtsov
2011-04-01 7:50 ` Luciano Coelho
1 sibling, 0 replies; 3+ messages in thread
From: Arik Nemtsov @ 2011-03-22 9:59 UTC (permalink / raw)
To: Luciano Coelho; +Cc: linux-wireless, Zaphir, Ruthy
On Tue, Mar 22, 2011 at 10:07, Arik Nemtsov <arik@wizery.com> wrote:
> Initialize the channel and band from mac80211 conf even when the FW is
> not yet loaded. This mitigates a bug in AP-mode where the channel was
> never changed from its initial setting after FW boot and was therefore
> never configured to FW.
Special thanks to Ruthy Zaphir <ruthyz@ti.com> for debugging this one.
Arik
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wl12xx: configure channel/band while FW is off
2011-03-22 8:07 [PATCH] wl12xx: configure channel/band while FW is off Arik Nemtsov
2011-03-22 9:59 ` Arik Nemtsov
@ 2011-04-01 7:50 ` Luciano Coelho
1 sibling, 0 replies; 3+ messages in thread
From: Luciano Coelho @ 2011-04-01 7:50 UTC (permalink / raw)
To: Arik Nemtsov; +Cc: linux-wireless
On Tue, 2011-03-22 at 10:07 +0200, Arik Nemtsov wrote:
> Initialize the channel and band from mac80211 conf even when the FW is
> not yet loaded. This mitigates a bug in AP-mode where the channel was
> never changed from its initial setting after FW boot and was therefore
> never configured to FW.
>
> Reported-by: Alexander Boukaty <alexanderb@ti.com>
> Signed-off-by: Arik Nemtsov <arik@wizery.com>
> ---
Applied, thank you.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-01 7:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-22 8:07 [PATCH] wl12xx: configure channel/band while FW is off Arik Nemtsov
2011-03-22 9:59 ` Arik Nemtsov
2011-04-01 7:50 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox