From: Johannes Berg <johannes@sipsolutions.net>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: Sujith <m.sujith@gmail.com>,
Rajkumar Manoharan <Rajkumar.Manoharan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath9k_htc: Cleanup HTC debugfs
Date: Fri, 15 Apr 2011 09:10:00 +0200 [thread overview]
Message-ID: <1302851401.3572.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110415070626.GB23429@vmraj-lnx.users.atheros.com>
On Fri, 2011-04-15 at 12:36 +0530, Rajkumar Manoharan wrote:
> > > @@ -150,6 +149,10 @@ static void ath9k_deinit_device(struct ath9k_htc_priv *priv)
> > > {
> > > struct ieee80211_hw *hw = priv->hw;
> > >
> > > + if (priv->debug.debugfs_phy) {
> > > + debugfs_remove_recursive(priv->debug.debugfs_phy);
> > > + priv->debug.debugfs_phy = NULL;
> > > + }
> >
> > It would be consistent to have this chunk of code in ath9k_htc_exit_debug().
> >
> I think mac80211 handles debugfs_remove_recursive. isn't it?
> If so, Shall I remove it?
cfg80211 will remove all per wiphy debugfs files, but you might want to
remove them before so nobody accesses them while you're uninitialising.
johannes
next prev parent reply other threads:[~2011-04-15 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 6:13 [PATCH 1/2] ath9k_htc: Add debugfs support to change debug mask Rajkumar Manoharan
2011-04-15 6:13 ` [PATCH 2/2] ath9k_htc: Cleanup HTC debugfs Rajkumar Manoharan
2011-04-15 6:40 ` Sujith
2011-04-15 7:06 ` Rajkumar Manoharan
2011-04-15 7:10 ` Johannes Berg [this message]
2011-04-15 7:12 ` Sujith
2011-04-15 6:26 ` [PATCH 1/2] ath9k_htc: Add debugfs support to change debug mask Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302851401.3572.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Rajkumar.Manoharan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m.sujith@gmail.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox