From: Sujith <m.sujith@gmail.com>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: [PATCH 2/2] ath9k_htc: Cleanup HTC debugfs
Date: Fri, 15 Apr 2011 12:10:03 +0530 [thread overview]
Message-ID: <19879.59459.480384.309998@gargle.gargle.HOWL> (raw)
In-Reply-To: <1302848033-7072-2-git-send-email-rmanoharan@atheros.com>
Rajkumar Manoharan wrote:
> + priv->debug.debugfs_phy = debugfs_create_dir("ath9k_htc",
> + priv->hw->wiphy->debugfsdir);
KBUILD_MODNAME can be used.
> + debugfs_create_file("debug", S_IRUSR, priv->debug.debugfs_phy,
> + priv, &fops_debug);
>
S_IWUSR.
> static void ath9k_deinit_priv(struct ath9k_htc_priv *priv)
> {
> - ath9k_htc_exit_debug(priv->ah);
> ath9k_hw_deinit(priv->ah);
> kfree(priv->ah);
> priv->ah = NULL;
> @@ -150,6 +149,10 @@ static void ath9k_deinit_device(struct ath9k_htc_priv *priv)
> {
> struct ieee80211_hw *hw = priv->hw;
>
> + if (priv->debug.debugfs_phy) {
> + debugfs_remove_recursive(priv->debug.debugfs_phy);
> + priv->debug.debugfs_phy = NULL;
> + }
It would be consistent to have this chunk of code in ath9k_htc_exit_debug().
Sujith
next prev parent reply other threads:[~2011-04-15 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 6:13 [PATCH 1/2] ath9k_htc: Add debugfs support to change debug mask Rajkumar Manoharan
2011-04-15 6:13 ` [PATCH 2/2] ath9k_htc: Cleanup HTC debugfs Rajkumar Manoharan
2011-04-15 6:40 ` Sujith [this message]
2011-04-15 7:06 ` Rajkumar Manoharan
2011-04-15 7:10 ` Johannes Berg
2011-04-15 7:12 ` Sujith
2011-04-15 6:26 ` [PATCH 1/2] ath9k_htc: Add debugfs support to change debug mask Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19879.59459.480384.309998@gargle.gargle.HOWL \
--to=m.sujith@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox