From: Joe Perches <joe@perches.com>
To: Roland Vossen <rvossen@broadcom.com>
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/3] staging: brcm80211: replaced WL_NONE with no_printk
Date: Thu, 21 Apr 2011 09:34:40 -0700 [thread overview]
Message-ID: <1303403680.24766.55.camel@Joe-Laptop> (raw)
In-Reply-To: <1303383725-1440-2-git-send-email-rvossen@broadcom.com>
On Thu, 2011-04-21 at 13:02 +0200, Roland Vossen wrote:
[]
> diff --git a/drivers/staging/brcm80211/brcmsmac/wl_dbg.h b/drivers/staging/brcm80211/brcmsmac/wl_dbg.h
> index 54af257..8705b40 100644
> --- a/drivers/staging/brcm80211/brcmsmac/wl_dbg.h
> +++ b/drivers/staging/brcm80211/brcmsmac/wl_dbg.h
> @@ -20,8 +20,6 @@
> /* wl_msg_level is a bit vector with defs in wlioctl.h */
> extern u32 wl_msg_level;
>
> -#define WL_NONE(fmt, args...) no_printk(fmt, ##args)
> -
I think you misunderstand the purpose of no_printk.
no_printk is used simply to validate format arguments
and not emit anything.
It's typically used for debugging like
#ifndef DEBUG
#define FOO_DBG(fmt, ...) printk(fmt, ##__VA_ARGS__)
#else
#define FOO_DBG(fmt, ...) no_printk(fmt, ##__VA_ARGS__)
#endif
What you've got here is effectively a comment.
More likely there was a mistake in the initial
conversion to of WL_NONE to no_printk.
next prev parent reply other threads:[~2011-04-21 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 11:02 [PATCH v3 0/3] staging: brcm80211: logging code clean up Roland Vossen
2011-04-21 11:02 ` [PATCH v3 1/3] staging: brcm80211: replaced WL_NONE with no_printk Roland Vossen
2011-04-21 16:34 ` Joe Perches [this message]
2011-04-21 17:10 ` Arend van Spriel
2011-04-21 17:14 ` Joe Perches
2011-04-21 17:32 ` Arend van Spriel
2011-04-21 11:02 ` [PATCH v3 2/3] staging: brcm80211: making device object accessible from wlc and phy Roland Vossen
2011-04-21 11:02 ` [PATCH v3 3/3] staging: brcm80211: replaced WL_ERROR with dev_err in two files Roland Vossen
2011-05-12 11:35 ` NULL pointer dereference in nl80211 Roland Vossen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303403680.24766.55.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox