From: "Arend van Spriel" <arend@broadcom.com>
To: "Joe Perches" <joe@perches.com>
Cc: "Roland Vossen" <rvossen@broadcom.com>,
"gregkh@suse.de" <gregkh@suse.de>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] staging: brcm80211: replaced WL_NONE with no_printk
Date: Thu, 21 Apr 2011 19:32:16 +0200 [thread overview]
Message-ID: <op.vuatn2bk3ri7v4@arend-laptop> (raw)
In-Reply-To: <1303406040.24766.65.camel@Joe-Laptop>
On Thu, 21 Apr 2011 19:14:00 +0200, Joe Perches <joe@perches.com> wrote:
> On Thu, 2011-04-21 at 19:10 +0200, Arend van Spriel wrote:
>> If you want to debug a specific source file you could do following in
>> that
>> particular source file:
>> #undef no_printk
>> #define no_printk printk
>> Not sure whether that is the intended use here.
>
> True, but that's entirely backwards
> and not very sensible either.
>
> For that you use pr_debug/dev_dbg/etc
> and then add #define DEBUG.
I see. I think WL_NONE was used like this and we mistakenly decided
no_printk was the equivalent. Thanks for the clarifications.
Gr. AvS
--
"The world is indeed comic, but the joke is on mankind." — H.P. Lovecraft
next prev parent reply other threads:[~2011-04-21 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 11:02 [PATCH v3 0/3] staging: brcm80211: logging code clean up Roland Vossen
2011-04-21 11:02 ` [PATCH v3 1/3] staging: brcm80211: replaced WL_NONE with no_printk Roland Vossen
2011-04-21 16:34 ` Joe Perches
2011-04-21 17:10 ` Arend van Spriel
2011-04-21 17:14 ` Joe Perches
2011-04-21 17:32 ` Arend van Spriel [this message]
2011-04-21 11:02 ` [PATCH v3 2/3] staging: brcm80211: making device object accessible from wlc and phy Roland Vossen
2011-04-21 11:02 ` [PATCH v3 3/3] staging: brcm80211: replaced WL_ERROR with dev_err in two files Roland Vossen
2011-05-12 11:35 ` NULL pointer dereference in nl80211 Roland Vossen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vuatn2bk3ri7v4@arend-laptop \
--to=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox