From: Luciano Coelho <coelho@ti.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: do not set queue_mapping directly
Date: Fri, 29 Apr 2011 23:09:27 +0300 [thread overview]
Message-ID: <1304107767.12586.165.camel@cumari> (raw)
In-Reply-To: <1303853264-2622-1-git-send-email-hauke@hauke-m.de>
On Tue, 2011-04-26 at 23:27 +0200, Hauke Mehrtens wrote:
> It is preferred to use the setter that to set queue_mapping directly.
> This also helps backporting in compat-wireless.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/wireless/wl12xx/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> index dad81f6..9d1d4d6 100644
> --- a/drivers/net/wireless/wl12xx/main.c
> +++ b/drivers/net/wireless/wl12xx/main.c
> @@ -1293,7 +1293,7 @@ static struct sk_buff *wl12xx_alloc_dummy_packet(struct wl1271 *wl)
> skb->priority = WL1271_TID_MGMT;
>
> /* Initialize all fields that might be used */
> - skb->queue_mapping = 0;
> + skb_set_queue_mapping(skb, 0);
> memset(IEEE80211_SKB_CB(skb), 0, sizeof(struct ieee80211_tx_info));
>
> return skb;
Thanks Hauke! This is indeed better than having to hack compat-wireless
to get it to work.
Applied.
--
Cheers,
Luca.
prev parent reply other threads:[~2011-04-29 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 21:27 [PATCH] wl12xx: do not set queue_mapping directly Hauke Mehrtens
2011-04-29 20:09 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304107767.12586.165.camel@cumari \
--to=coelho@ti.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox