* [PATCH] wl12xx: do not set queue_mapping directly
@ 2011-04-26 21:27 Hauke Mehrtens
2011-04-29 20:09 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Hauke Mehrtens @ 2011-04-26 21:27 UTC (permalink / raw)
To: coelho; +Cc: linux-wireless, Hauke Mehrtens
It is preferred to use the setter that to set queue_mapping directly.
This also helps backporting in compat-wireless.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/net/wireless/wl12xx/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index dad81f6..9d1d4d6 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -1293,7 +1293,7 @@ static struct sk_buff *wl12xx_alloc_dummy_packet(struct wl1271 *wl)
skb->priority = WL1271_TID_MGMT;
/* Initialize all fields that might be used */
- skb->queue_mapping = 0;
+ skb_set_queue_mapping(skb, 0);
memset(IEEE80211_SKB_CB(skb), 0, sizeof(struct ieee80211_tx_info));
return skb;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wl12xx: do not set queue_mapping directly
2011-04-26 21:27 [PATCH] wl12xx: do not set queue_mapping directly Hauke Mehrtens
@ 2011-04-29 20:09 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2011-04-29 20:09 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: linux-wireless
On Tue, 2011-04-26 at 23:27 +0200, Hauke Mehrtens wrote:
> It is preferred to use the setter that to set queue_mapping directly.
> This also helps backporting in compat-wireless.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> drivers/net/wireless/wl12xx/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> index dad81f6..9d1d4d6 100644
> --- a/drivers/net/wireless/wl12xx/main.c
> +++ b/drivers/net/wireless/wl12xx/main.c
> @@ -1293,7 +1293,7 @@ static struct sk_buff *wl12xx_alloc_dummy_packet(struct wl1271 *wl)
> skb->priority = WL1271_TID_MGMT;
>
> /* Initialize all fields that might be used */
> - skb->queue_mapping = 0;
> + skb_set_queue_mapping(skb, 0);
> memset(IEEE80211_SKB_CB(skb), 0, sizeof(struct ieee80211_tx_info));
>
> return skb;
Thanks Hauke! This is indeed better than having to hack compat-wireless
to get it to work.
Applied.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-29 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-26 21:27 [PATCH] wl12xx: do not set queue_mapping directly Hauke Mehrtens
2011-04-29 20:09 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox