Re: [PATCH v5 0/6] NFC subsystem

Re: [PATCH v5 0/6] NFC subsystem

[Elias, Ilan]

Hi Aloisio,

I went over the userspace interface and it seems to me 
that it's very much following the PN533 chip interface.

As you probably know, the NFC forum is in the process of defining 
a new industry standard for the NFC Controller Interface (NCI).
All NFC chips in the near future will probably support the NCI, 
which will provide a generic and standard interface for NFC functionality.

I think that your current userspace interface might be too specific 
for PN533 chip, and might not expose all the required NFC functionality.

A similar case with Bluetooth, where HCI is the industry standard which 
is supported by most Bluetooth chips, thus BlueZ support it of course.

Doesn't it make more sense to make the userspace interface more similar to the NCI?
I think this solution will make the Linux Kernel better prepare to support the 
future NFC controllers.

Thanks & BR,
Ilan


On Fri, Jul 01, 2011 at 07:31:32PM -0300, Aloisio Almeida Jr wrote:
> This version has only debug related changes.
> 
>  1. NFC_*() macros were renamed to nfc_*(). For err and info nfc_printk() is
>     called. For dbg pr_debug() is called.
>  2. nfc_dev_*() macros were created to be used by device drivers. These macros
>     use dev_*().
>  3. The macros does not have __func__ anymore.
> 
> Aloisio Almeida Jr (3):
>   NFC: add NFC socket family
>   NFC: pn533: add NXP pn533 nfc device driver
>   NFC: add Documentation/networking/nfc.txt
> 
> Lauro Ramos Venancio (3):
>   NFC: add nfc subsystem core
>   NFC: add nfc generic netlink interface
>   NFC: add the NFC socket raw protocol
> 
>  Documentation/networking/nfc.txt |  128 +++
>  drivers/Kconfig                  |    2 -
>  drivers/Makefile                 |    1 +
>  drivers/nfc/Kconfig              |   24 +-
>  drivers/nfc/Makefile             |    3 +
>  drivers/nfc/pn533.c              | 1632 ++++++++++++++++++++++++++++++++++++++
>  include/linux/nfc.h              |  126 +++
>  include/linux/socket.h           |    4 +-
>  include/net/nfc.h                |  156 ++++
>  net/Kconfig                      |    1 +
>  net/Makefile                     |    1 +
>  net/core/sock.c                  |    6 +-
>  net/nfc/Kconfig                  |   16 +
>  net/nfc/Makefile                 |    7 +
>  net/nfc/af_nfc.c                 |   98 +++
>  net/nfc/core.c                   |  468 +++++++++++
>  net/nfc/netlink.c                |  537 +++++++++++++
>  net/nfc/nfc.h                    |  117 +++
>  net/nfc/rawsock.c                |  354 +++++++++
>  19 files changed, 3663 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/networking/nfc.txt
>  create mode 100644 drivers/nfc/pn533.c
>  create mode 100644 include/linux/nfc.h
>  create mode 100644 include/net/nfc.h
>  create mode 100644 net/nfc/Kconfig
>  create mode 100644 net/nfc/Makefile
>  create mode 100644 net/nfc/af_nfc.c
>  create mode 100644 net/nfc/core.c
>  create mode 100644 net/nfc/netlink.c
>  create mode 100644 net/nfc/nfc.h
>  create mode 100644 net/nfc/rawsock.c
> 
> -- 
> 1.7.5.4

Re: [PATCH v5 0/6] NFC subsystem

[Samuel Ortiz]

Hi Ilan,

On Sun, 2011-07-10 at 16:16 +0200, Elias, Ilan wrote:
> Hi Aloisio,
> 
> I went over the userspace interface and it seems to me 
> that it's very much following the PN533 chip interface.
> 
> As you probably know, the NFC forum is in the process of defining 
> a new industry standard for the NFC Controller Interface (NCI).
> All NFC chips in the near future will probably support the NCI,
I suppose that's arguable, especialy the "All" and "near future" terms
of your statement :)
Moreover, as far as I know, most NFC chips are currently HCI based and I
expect the transition from HCI to NCI to not be that fast.


>  
> which will provide a generic and standard interface for NFC functionality.
> 
> I think that your current userspace interface might be too specific 
> for PN533 chip, and might not expose all the required NFC functionality.
The idea for the current netlink userspace API is to be a generic and
high level one. It should allow for userspace components to build their
target management code and NDEF  parsing code on top of it, without
having to know if the below HW is HCI, NCI or anything else based.
Also, please note that the current API is going to be soon extended to
support target mode.


> A similar case with Bluetooth, where HCI is the industry standard which 
> is supported by most Bluetooth chips, thus BlueZ support it of course.
We plan to implement the NFC HCI (as in ETSI 102 622) code as a kernel
component, and we're currently working on that. HCI NFC based chipsets
will register against this layer which will then talk to the NFC core
layer.
The same architecture would hopefully work with NCI, although due to the
lack of currently available public NCI specs, I can't guarantee that it
won't require some small adjustments.

> Doesn't it make more sense to make the userspace interface more similar to the NCI?
Could you please point us at a publically available description of that
interface ?

Cheers,
Samuel.

RE: [PATCH v5 0/6] NFC subsystem

[Elias, Ilan]

Hi Samuel,

Thanks for your reply.

> -----Original Message-----
> From: Samuel Ortiz [mailto:samuel@sortiz.org]
> Sent: Monday, July 11, 2011 3:46 AM
> To: Elias, Ilan
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v5 0/6] NFC subsystem
> 
> Hi Ilan,
> 
> On Sun, 2011-07-10 at 16:16 +0200, Elias, Ilan wrote:
> > Hi Aloisio,
> >
> > I went over the userspace interface and it seems to me
> > that it's very much following the PN533 chip interface.
> >
> > As you probably know, the NFC forum is in the process of defining
> > a new industry standard for the NFC Controller Interface (NCI).
> > All NFC chips in the near future will probably support the NCI,
> I suppose that's arguable, especialy the "All" and "near future" terms
> of your statement :)
> Moreover, as far as I know, most NFC chips are currently HCI based and I
> expect the transition from HCI to NCI to not be that fast.
I assume you're right and it might take some time for the transition to occur, but still I believe most of NFC chips will support NCI in the near future. Thus, I think the userspace interface should also take into consideration the NCI.

> 
> 
> >
> > which will provide a generic and standard interface for NFC
> > functionality.
> >
> > I think that your current userspace interface might be too specific
> > for PN533 chip, and might not expose all the required NFC functionality.
> The idea for the current netlink userspace API is to be a generic and
> high level one. It should allow for userspace components to build their
> target management code and NDEF  parsing code on top of it, without
> having to know if the below HW is HCI, NCI or anything else based.
> Also, please note that the current API is going to be soon extended to
> support target mode.
I agree that the userspace API should be generic and high level one, so it will be able to support all underlying HW interface, e.g. HCI and NCI.

> 
> 
> > A similar case with Bluetooth, where HCI is the industry standard which
> > is supported by most Bluetooth chips, thus BlueZ support it of course.
> We plan to implement the NFC HCI (as in ETSI 102 622) code as a kernel
> component, and we're currently working on that. HCI NFC based chipsets
> will register against this layer which will then talk to the NFC core
> layer.
> The same architecture would hopefully work with NCI, although due to the
> lack of currently available public NCI specs, I can't guarantee that it
> won't require some small adjustments.
> 
> > Doesn't it make more sense to make the userspace interface more similar
> > to the NCI?
> Could you please point us at a publically available description of that
> interface ?
You can download latest NCI spec and check its current status in the NFC forum website at:
http://www.nfc-forum.org/home/

> 
> Cheers,
> Samuel.
> 
Thanks & BR,
Ilan

[PATCH v5 0/6] NFC subsystem

[Aloisio Almeida Jr]

This version has only debug related changes.

 1. NFC_*() macros were renamed to nfc_*(). For err and info nfc_printk() is
    called. For dbg pr_debug() is called.
 2. nfc_dev_*() macros were created to be used by device drivers. These macros
    use dev_*().
 3. The macros does not have __func__ anymore.

Aloisio Almeida Jr (3):
  NFC: add NFC socket family
  NFC: pn533: add NXP pn533 nfc device driver
  NFC: add Documentation/networking/nfc.txt

Lauro Ramos Venancio (3):
  NFC: add nfc subsystem core
  NFC: add nfc generic netlink interface
  NFC: add the NFC socket raw protocol

 Documentation/networking/nfc.txt |  128 +++
 drivers/Kconfig                  |    2 -
 drivers/Makefile                 |    1 +
 drivers/nfc/Kconfig              |   24 +-
 drivers/nfc/Makefile             |    3 +
 drivers/nfc/pn533.c              | 1632 ++++++++++++++++++++++++++++++++++++++
 include/linux/nfc.h              |  126 +++
 include/linux/socket.h           |    4 +-
 include/net/nfc.h                |  156 ++++
 net/Kconfig                      |    1 +
 net/Makefile                     |    1 +
 net/core/sock.c                  |    6 +-
 net/nfc/Kconfig                  |   16 +
 net/nfc/Makefile                 |    7 +
 net/nfc/af_nfc.c                 |   98 +++
 net/nfc/core.c                   |  468 +++++++++++
 net/nfc/netlink.c                |  537 +++++++++++++
 net/nfc/nfc.h                    |  117 +++
 net/nfc/rawsock.c                |  354 +++++++++
 19 files changed, 3663 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/networking/nfc.txt
 create mode 100644 drivers/nfc/pn533.c
 create mode 100644 include/linux/nfc.h
 create mode 100644 include/net/nfc.h
 create mode 100644 net/nfc/Kconfig
 create mode 100644 net/nfc/Makefile
 create mode 100644 net/nfc/af_nfc.c
 create mode 100644 net/nfc/core.c
 create mode 100644 net/nfc/netlink.c
 create mode 100644 net/nfc/nfc.h
 create mode 100644 net/nfc/rawsock.c

-- 
1.7.5.4

Re: [PATCH v5 0/6] NFC subsystem

[John W. Linville]

I'm merging this series.  Please post any further changes as patches on top.

John

On Fri, Jul 01, 2011 at 07:31:32PM -0300, Aloisio Almeida Jr wrote:
> This version has only debug related changes.
> 
>  1. NFC_*() macros were renamed to nfc_*(). For err and info nfc_printk() is
>     called. For dbg pr_debug() is called.
>  2. nfc_dev_*() macros were created to be used by device drivers. These macros
>     use dev_*().
>  3. The macros does not have __func__ anymore.
> 
> Aloisio Almeida Jr (3):
>   NFC: add NFC socket family
>   NFC: pn533: add NXP pn533 nfc device driver
>   NFC: add Documentation/networking/nfc.txt
> 
> Lauro Ramos Venancio (3):
>   NFC: add nfc subsystem core
>   NFC: add nfc generic netlink interface
>   NFC: add the NFC socket raw protocol
> 
>  Documentation/networking/nfc.txt |  128 +++
>  drivers/Kconfig                  |    2 -
>  drivers/Makefile                 |    1 +
>  drivers/nfc/Kconfig              |   24 +-
>  drivers/nfc/Makefile             |    3 +
>  drivers/nfc/pn533.c              | 1632 ++++++++++++++++++++++++++++++++++++++
>  include/linux/nfc.h              |  126 +++
>  include/linux/socket.h           |    4 +-
>  include/net/nfc.h                |  156 ++++
>  net/Kconfig                      |    1 +
>  net/Makefile                     |    1 +
>  net/core/sock.c                  |    6 +-
>  net/nfc/Kconfig                  |   16 +
>  net/nfc/Makefile                 |    7 +
>  net/nfc/af_nfc.c                 |   98 +++
>  net/nfc/core.c                   |  468 +++++++++++
>  net/nfc/netlink.c                |  537 +++++++++++++
>  net/nfc/nfc.h                    |  117 +++
>  net/nfc/rawsock.c                |  354 +++++++++
>  19 files changed, 3663 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/networking/nfc.txt
>  create mode 100644 drivers/nfc/pn533.c
>  create mode 100644 include/linux/nfc.h
>  create mode 100644 include/net/nfc.h
>  create mode 100644 net/nfc/Kconfig
>  create mode 100644 net/nfc/Makefile
>  create mode 100644 net/nfc/af_nfc.c
>  create mode 100644 net/nfc/core.c
>  create mode 100644 net/nfc/netlink.c
>  create mode 100644 net/nfc/nfc.h
>  create mode 100644 net/nfc/rawsock.c
> 
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.