Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, Kalle Valo <kvalo@adurom.com>
Subject: Re: [PATCHv2 2/2] mac80211: Don't use a buf_size=0 in ADDBA requests
Date: Mon, 08 Aug 2011 10:46:41 +0200	[thread overview]
Message-ID: <1312793201.4372.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAGXE3d9EwS8wMZRYUxAz5FqiTzRZiAATmOcWaG17vbcqryH7ZQ@mail.gmail.com> (sfid-20110808_104107_910363_06EB83BE)

On Mon, 2011-08-08 at 10:40 +0200, Helmut Schaa wrote:
> On Mon, Aug 8, 2011 at 10:29 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > So, are you saying the problem with getting 0 in replies is solved by
> > not sending 0 in requests?
> 
> This specific device always replies with a buf_size=0 _if_ we send an
> ADDBA request
> with a buf_size=0.
> 
> The first patch in this series solves a problem were mac80211 would
> buffer frames to
> this STA forever when the ADDBA response contains a buf_size=0 since the BA
> session is stuck in an intermediate state.
> 
> However, the AVM Fritz Stick N client behaves correctly if we're using
> a buf_size != 0
> in the ADDBA request. This is a bug in the Fritz Stick Windows driver
> (it should use
> the default size of its rx reorder buffer if the ADDBA request
> contains 0). However, this
> bug can be worked around by using a buf_size != 0 in ADDBA requests. And that's
> what the second patch does.
> 
> Hope this clarifies my intention :)

Yes, thanks.

johannes


  reply	other threads:[~2011-08-08  8:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26 10:18 [PATCH 1/2] mac80211: Stop TX BA session if buf_size is zero Helmut Schaa
2011-07-26 10:18 ` [PATCH 2/2] mac80211: Don't use a buf_size=0 in ADDBA requests Helmut Schaa
2011-08-05  8:15   ` Kalle Valo
2011-08-05  8:35     ` Helmut Schaa
2011-08-05  8:54       ` Kalle Valo
2011-08-05  9:46   ` [PATCHv2 " Helmut Schaa
2011-08-08  8:29     ` Johannes Berg
2011-08-08  8:40       ` Helmut Schaa
2011-08-08  8:46         ` Johannes Berg [this message]
2011-08-08  8:50 ` [PATCH 1/2] mac80211: Stop TX BA session if buf_size is zero Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312793201.4372.9.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=helmut.schaa@googlemail.com \
    --cc=kvalo@adurom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox