From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, anagar6@uic.edu,
devel@lists.open80211s.org, linville@tuxdriver.com
Subject: Re: [PATCH 5/6] mac80211: add WMM IE to mesh frames
Date: Thu, 20 Oct 2011 19:51:44 +0200 [thread overview]
Message-ID: <1319133104.17101.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAG6hwVMUhJ=nV=6N+DpoagKWJxMjythPYMYCCzEb=mTr6TfytQ@mail.gmail.com> (sfid-20111020_194134_871213_05E4800F)
On Thu, 2011-10-20 at 10:41 -0700, Thomas Pedersen wrote:
> On Thu, Oct 20, 2011 at 4:16 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Wed, 2011-10-19 at 18:03 -0700, Thomas Pedersen wrote:
> >> Include the WMM IE in mesh peering and beacon frames. This is needed
> >> tell any potential peers what our WMM / EDCA parameters are.
> >
> > The goal seems fine but why bother building the WMM IE out of the actual
> > TX queue configuration? Shouldn't it normally be the other way around?
> > But I have no idea how QoS is supposed to work in a mesh...
>
> I'm not sure what you mean, this is the only way to get the WMM
> parameters? Usually these are just set with ieee80211_set_wmm_defaul()
> on bringing up the interface.
Right, but
a) if you're using just the default, no need to derive from the default
b) should they be changeable?
johannes
next prev parent reply other threads:[~2011-10-20 17:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 1:03 [PATCH 0/6] HT support for mesh Thomas Pedersen
2011-10-20 1:03 ` [PATCH 1/6] mac80211: Add HT helper functions Thomas Pedersen
2011-10-20 1:03 ` [PATCH 2/6] mac80211: add HT IEs to mesh frames Thomas Pedersen
2011-10-20 1:03 ` [PATCH 3/6] mac80211: set HT capabilities for mesh peer Thomas Pedersen
2011-10-20 1:03 ` [PATCH 4/6] mac80211: allow frame aggregation for mesh Thomas Pedersen
2011-10-20 9:46 ` Christian Lamparter
2011-10-20 16:48 ` Thomas Pedersen
2011-10-20 1:03 ` [PATCH 5/6] mac80211: add WMM IE to mesh frames Thomas Pedersen
2011-10-20 11:16 ` Johannes Berg
2011-10-20 17:41 ` Thomas Pedersen
2011-10-20 17:51 ` Johannes Berg [this message]
2011-10-20 17:56 ` Thomas Pedersen
2011-10-20 18:03 ` Johannes Berg
2011-10-20 18:08 ` Thomas Pedersen
2011-10-20 18:11 ` Johannes Berg
2011-10-20 18:14 ` Thomas Pedersen
2011-10-20 18:22 ` Johannes Berg
2011-10-20 1:03 ` [PATCH 6/6] mac80211: check mesh peer's WMM parameters Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319133104.17101.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anagar6@uic.edu \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox