From: Christian Lamparter <chunkeey@googlemail.com>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, anagar6@uic.edu,
devel@lists.open80211s.org, johannes@sipsolutions.net,
linville@tuxdriver.com
Subject: Re: [PATCH 4/6] mac80211: allow frame aggregation for mesh
Date: Thu, 20 Oct 2011 11:46:00 +0200 [thread overview]
Message-ID: <201110201146.00505.chunkeey@googlemail.com> (raw)
In-Reply-To: <1319072606-28291-5-git-send-email-thomas@cozybit.com>
On Thursday, October 20, 2011 03:03:24 AM Thomas Pedersen wrote:
> Signed-off-by: Thomas Pedersen <thomas@cozybit.com>
> Signed-off-by: Ashok Nagarajan <anagar6@uic.edu>
> ---
> net/mac80211/agg-rx.c | 3 ++-
> net/mac80211/agg-tx.c | 4 +++-
> net/mac80211/ht.c | 3 ++-
> net/mac80211/rx.c | 1 +
> 4 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
> index 2ac0339..36c2836 100644
> --- a/net/mac80211/agg-tx.c
> +++ b/net/mac80211/agg-tx.c
> @@ -378,6 +379,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
> * by drivers or the standard.
> */
> if (sdata->vif.type != NL80211_IFTYPE_STATION &&
> + sdata->vif.type != NL80211_IFTYPE_MESH_POINT &&
> sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
> sdata->vif.type != NL80211_IFTYPE_AP)
> return -EINVAL;
just a nitpick, but it looks like the comment in agg-tx.c
seems to be a little out of date. Hence, would you mind
removing it as well?
/*
* The aggregation code is not prepared to handle
* anything but STA/AP due to the BSSID handling.
* IBSS could work in the code but isn't supported
* by drivers or the standard.
*/
if (sdata->vif.type != NL80211_IFTYPE_STATION &&
sdata->vif.type != NL80211_IFTYPE_AP_VLAN &&
sdata->vif.type != NL80211_IFTYPE_AP)
return -EINVAL;
Regards,
Chr
next prev parent reply other threads:[~2011-10-20 9:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 1:03 [PATCH 0/6] HT support for mesh Thomas Pedersen
2011-10-20 1:03 ` [PATCH 1/6] mac80211: Add HT helper functions Thomas Pedersen
2011-10-20 1:03 ` [PATCH 2/6] mac80211: add HT IEs to mesh frames Thomas Pedersen
2011-10-20 1:03 ` [PATCH 3/6] mac80211: set HT capabilities for mesh peer Thomas Pedersen
2011-10-20 1:03 ` [PATCH 4/6] mac80211: allow frame aggregation for mesh Thomas Pedersen
2011-10-20 9:46 ` Christian Lamparter [this message]
2011-10-20 16:48 ` Thomas Pedersen
2011-10-20 1:03 ` [PATCH 5/6] mac80211: add WMM IE to mesh frames Thomas Pedersen
2011-10-20 11:16 ` Johannes Berg
2011-10-20 17:41 ` Thomas Pedersen
2011-10-20 17:51 ` Johannes Berg
2011-10-20 17:56 ` Thomas Pedersen
2011-10-20 18:03 ` Johannes Berg
2011-10-20 18:08 ` Thomas Pedersen
2011-10-20 18:11 ` Johannes Berg
2011-10-20 18:14 ` Thomas Pedersen
2011-10-20 18:22 ` Johannes Berg
2011-10-20 1:03 ` [PATCH 6/6] mac80211: check mesh peer's WMM parameters Thomas Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110201146.00505.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=anagar6@uic.edu \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox