* [PATCH 3.2] cfg80211: allow setting TXQ parameters only in AP mode
@ 2011-11-03 13:50 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2011-11-03 13:50 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Eliad Peller
From: Johannes Berg <johannes.berg@intel.com>
In other modes the parameters should not be set.
Right now, mac80211 will set them, even if the
user asked for setting them on VLANs which the
driver doesn't know about, causing all kinds of
trouble.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/wireless/nl80211.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/net/wireless/nl80211.c 2011-11-03 14:41:42.000000000 +0100
+++ b/net/wireless/nl80211.c 2011-11-03 14:47:23.000000000 +0100
@@ -1252,6 +1252,12 @@ static int nl80211_set_wiphy(struct sk_b
goto bad_res;
}
+ if (netdev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
+ netdev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO) {
+ result = -EINVAL;
+ goto bad_res;
+ }
+
nla_for_each_nested(nl_txq_params,
info->attrs[NL80211_ATTR_WIPHY_TXQ_PARAMS],
rem_txq_params) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-11-03 13:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-03 13:50 [PATCH 3.2] cfg80211: allow setting TXQ parameters only in AP mode Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox