* [PATCH] wl12xx: silence tx_attr uninitialized warning in wl1271_tx_fill_hdr
@ 2011-12-08 21:15 John W. Linville
2011-12-08 22:08 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2011-12-08 21:15 UTC (permalink / raw)
To: linux-wireless; +Cc: Luciano Coelho, John W. Linville
CC [M] drivers/net/wireless/wl12xx/tx.o
drivers/net/wireless/wl12xx/tx.c: In function ‘wl1271_tx_fill_hdr’:
drivers/net/wireless/wl12xx/tx.c:288:6: warning: ‘tx_attr’ may be used uninitialized in this function
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/wl12xx/tx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/tx.c b/drivers/net/wireless/wl12xx/tx.c
index 36eb0d6..7d727ee 100644
--- a/drivers/net/wireless/wl12xx/tx.c
+++ b/drivers/net/wireless/wl12xx/tx.c
@@ -285,7 +285,7 @@ static void wl1271_tx_fill_hdr(struct wl1271 *wl, struct wl12xx_vif *wlvif,
struct wl1271_tx_hw_descr *desc;
int aligned_len, ac, rate_idx;
s64 hosttime;
- u16 tx_attr;
+ u16 tx_attr = 0;
bool is_dummy;
desc = (struct wl1271_tx_hw_descr *) skb->data;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wl12xx: silence tx_attr uninitialized warning in wl1271_tx_fill_hdr
2011-12-08 21:15 [PATCH] wl12xx: silence tx_attr uninitialized warning in wl1271_tx_fill_hdr John W. Linville
@ 2011-12-08 22:08 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2011-12-08 22:08 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, eliad
On Thu, 2011-12-08 at 16:15 -0500, John W. Linville wrote:
> CC [M] drivers/net/wireless/wl12xx/tx.o
> drivers/net/wireless/wl12xx/tx.c: In function ‘wl1271_tx_fill_hdr’:
> drivers/net/wireless/wl12xx/tx.c:288:6: warning: ‘tx_attr’ may be used uninitialized in this function
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
Ooops! Sorry, John, and thanks for fixing it. My compiler (gcc for arm)
doesn't seem to report it.
We had already seen this and it had been fix in our internal tree.
Unfortunately we forgot to include this when sending upstream.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-08 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-08 21:15 [PATCH] wl12xx: silence tx_attr uninitialized warning in wl1271_tx_fill_hdr John W. Linville
2011-12-08 22:08 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox