* [PATCH] wl12xx: minor fix in sched_scan_ssid_list
@ 2011-12-07 10:37 Eyal Shapira
2011-12-13 9:28 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Eyal Shapira @ 2011-12-07 10:37 UTC (permalink / raw)
To: Luciano Coelho; +Cc: linux-wireless
The user can pass broadcast SSID (ssid="") in the list of SSIDs for active scan.
In this case the loop was attempting to match SSIDs in the filter
list to this empty entry and marking them as HIDDEN (sending probe
request) by mistake
Signed-off-by: Eyal Shapira <eyal@wizery.com>
---
drivers/net/wireless/wl12xx/scan.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
index 330d678..8599dab 100644
--- a/drivers/net/wireless/wl12xx/scan.c
+++ b/drivers/net/wireless/wl12xx/scan.c
@@ -572,6 +572,9 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl,
* so they're used in probe requests.
*/
for (i = 0; i < req->n_ssids; i++) {
+ if (!req->ssids[i].ssid_len)
+ continue;
+
for (j = 0; j < cmd->n_ssids; j++)
if (!memcmp(req->ssids[i].ssid,
cmd->ssids[j].ssid,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wl12xx: minor fix in sched_scan_ssid_list
2011-12-07 10:37 [PATCH] wl12xx: minor fix in sched_scan_ssid_list Eyal Shapira
@ 2011-12-13 9:28 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2011-12-13 9:28 UTC (permalink / raw)
To: Eyal Shapira; +Cc: linux-wireless
On Wed, 2011-12-07 at 12:37 +0200, Eyal Shapira wrote:
> The user can pass broadcast SSID (ssid="") in the list of SSIDs for active scan.
> In this case the loop was attempting to match SSIDs in the filter
> list to this empty entry and marking them as HIDDEN (sending probe
> request) by mistake
>
> Signed-off-by: Eyal Shapira <eyal@wizery.com>
> ---
This has also been applied and pushed last week.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-13 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-07 10:37 [PATCH] wl12xx: minor fix in sched_scan_ssid_list Eyal Shapira
2011-12-13 9:28 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox