From: Luciano Coelho <coelho@ti.com>
To: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Kalle Valo <kvalo@qca.qualcomm.com>
Subject: Re: [PATCH] atheros: force endian checks on atheros wireless drivers
Date: Wed, 21 Dec 2011 13:10:40 +0200 [thread overview]
Message-ID: <1324465840.2182.198.camel@cumari> (raw)
In-Reply-To: <1324408728-20300-1-git-send-email-rodrigue@qca.qualcomm.com>
On Tue, 2011-12-20 at 11:18 -0800, Luis R. Rodriguez wrote:
> From: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
>
> Please NACK nasty patches.
>
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/Makefile b/drivers/net/wireless/ath/Makefile
> index d121469..d716b74 100644
> --- a/drivers/net/wireless/ath/Makefile
> +++ b/drivers/net/wireless/ath/Makefile
> @@ -11,3 +11,4 @@ ath-objs := main.o \
> key.o
>
> ath-$(CONFIG_ATH_DEBUG) += debug.o
> +ccflags-y += -D__CHECK_ENDIAN__
Doesn't this force everyone who compiles the modules (even
non-developers) to have sparse installed? Is it really what we want?
If that's the case, shouldn't we do this in a higher level, maybe
enforce sparse check for everything? Of course the number of warnings
would explode, but we could at least do it for all the wireless code in
a first phase?
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-12-21 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 19:18 [PATCH] atheros: force endian checks on atheros wireless drivers Luis R. Rodriguez
2011-12-21 11:10 ` Luciano Coelho [this message]
2011-12-21 15:14 ` Johannes Berg
2011-12-21 15:26 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324465840.2182.198.camel@cumari \
--to=coelho@ti.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox