From: Luciano Coelho <coelho@ti.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Kalle Valo <kvalo@qca.qualcomm.com>,
arik@wizery.com
Subject: Re: [PATCH] atheros: force endian checks on atheros wireless drivers
Date: Wed, 21 Dec 2011 17:26:28 +0200 [thread overview]
Message-ID: <1324481188.2182.243.camel@cumari> (raw)
In-Reply-To: <1324480449.3401.7.camel@jlt3.sipsolutions.net>
On Wed, 2011-12-21 at 16:14 +0100, Johannes Berg wrote:
> On Wed, 2011-12-21 at 13:10 +0200, Luciano Coelho wrote:
>
> > > ath-$(CONFIG_ATH_DEBUG) += debug.o
> > > +ccflags-y += -D__CHECK_ENDIAN__
> >
> > Doesn't this force everyone who compiles the modules (even
> > non-developers) to have sparse installed? Is it really what we want?
>
> No. It just forces everyone who does use sparse to also use it for
> endian checks. I do the same in all code I maintain, take a look :-)
Ah, I get it now. sparse will only run if C=[12] is passed in the make
command.
I'll probably add the same in wl12xx.
It would be nice to have a way to enforce developers to run sparse.
Maybe public humiliation works, but it's not the most efficient way. :)
--
Cheers,
Luca.
prev parent reply other threads:[~2011-12-21 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 19:18 [PATCH] atheros: force endian checks on atheros wireless drivers Luis R. Rodriguez
2011-12-21 11:10 ` Luciano Coelho
2011-12-21 15:14 ` Johannes Berg
2011-12-21 15:26 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324481188.2182.243.camel@cumari \
--to=coelho@ti.com \
--cc=arik@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox