From: Luciano Coelho <coelho@ti.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: mcgrof@gmail.com, mcgrof@qca.qualcomm.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] compat-wireless: remove platform_device_id for kernel < 2.6.30
Date: Fri, 23 Dec 2011 10:58:14 +0200 [thread overview]
Message-ID: <1324630694.2182.325.camel@cumari> (raw)
In-Reply-To: <1324586850-5212-3-git-send-email-hauke@hauke-m.de>
On Thu, 2011-12-22 at 21:47 +0100, Hauke Mehrtens wrote:
> Kernel < 2.6.30 do not support struct platform_device_id, so remove it
> for them and hope that the probing will reject an invalid device.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
This is not going to work. The only way the wl12xx module gets probed
is when a "wl12xx" platform device is added to the system. The
wl12xx_sdio or wl12xx_spi module instantiates a platform device with
"wl12xx" as the name, which causes the wl12xx module to be probed.
I don't know how modules handling platform devices were probed pre-.30.
Does anyone know?
Anything before 2.6.30 is *ancient*, and anyway, even before this change
we already needed changes in the "outer" kernel to get wl12xx to work.
The question is, should we even bother compiling wl12xx if the kernel is
< .30?
I'll update our wikipage to say athat starting from compat-wireless 3.2,
additional changes are required for < 2.6.30.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-12-23 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 20:47 [PATCH 0/6] compat-wireless: various fixes Hauke Mehrtens
2011-12-22 20:47 ` [PATCH 1/6] compat-wireless: compile fix for commit patches/09-threaded-irq.patch Hauke Mehrtens
2011-12-22 20:47 ` [PATCH 2/6] compat-wireless: remove platform_device_id for kernel < 2.6.30 Hauke Mehrtens
2011-12-23 8:58 ` Luciano Coelho [this message]
2011-12-23 15:00 ` Luis R. Rodriguez
2011-12-23 15:04 ` Luciano Coelho
2011-12-22 20:47 ` [PATCH 3/6] compat-wireless: CONFIG_BT_L2CAP and CONFIG_BT_SCO removed Hauke Mehrtens
2011-12-22 20:47 ` [PATCH 4/6] compat-wireless: make patches apply again Hauke Mehrtens
2011-12-22 20:47 ` [PATCH 5/6] compat-wireless: use other workqueue Hauke Mehrtens
2011-12-22 20:47 ` [PATCH 6/6] compat-wireless: no trans_start on netdev_queue Hauke Mehrtens
2011-12-23 15:16 ` [PATCH 0/6] compat-wireless: various fixes Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324630694.2182.325.camel@cumari \
--to=coelho@ti.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=mcgrof@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox