Re: [PATCH] rtl8187: Add Ad-hoc mode

[Hin-Tak Leung <htl10@users.sourceforge.net>]

--- On Sun, 19/2/12, Larry Finger <Larry.Finger@lwfinger.net> wrote:

> On 02/19/2012 01:54 PM, Attila
> Fazekas wrote:
> > Add AD-HOC support to the rtl8187 based on the rtl8180
> source
> > 
> > Signed-off-by: Attila Fazekas<turul64@gmail.com>
> > ---
> > diff --git
> a/drivers/net/wireless/rtl818x/rtl8187/dev.c
> > b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> > index 638fbef..f8f9186 100644
> > --- a/drivers/net/wireless/rtl818x/rtl8187/dev.c
> > +++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> > @@ -232,6 +232,7 @@ static void rtl8187_tx(struct
> ieee80211_hw *dev,
> > struct sk_buff *skb)
> >   {
> >       struct rtl8187_priv
> *priv = dev->priv;
> >       struct
> ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
> > +    struct ieee80211_hdr *tx_hdr =
>     (struct ieee80211_hdr *)(skb->data);
> >       unsigned int ep;
> >       void *buf;
> >       struct urb *urb;
> > @@ -249,7 +250,7 @@ static void rtl8187_tx(struct
> ieee80211_hw *dev,
> > struct sk_buff *skb)
> 
> This patch was mangled by your mailer. See how the line
> above is wrapped? In addition, the tabs seem to have been
> replaced by spaces.
> 
> To test what works, you should mail a patch to yourself and
> see if the version extracted from your mailer still
> applies.

I am curious about this patch - does it take this amount of driver-specific effort to make ad-hoc mode work? Master mode is preferably handled in a generic way by hostapd... "Add AD-HOC support to the rtl8187 based on the rtl8180 source" - could some refactor be done?

Hin-Tak