Re: [PATCH] rtl8187: Add Ad-hoc mode

[Hin-Tak Leung <htl10@users.sourceforge.net>]

--- On Wed, 22/2/12, Larry Finger <Larry.Finger@lwfinger.net> wrote:

<snipped bits>
> > As Larry requested - please send the patch without
> munching from your
> > e-mail client. Since you are on gmail, I could offer a
> little advice on git-send-email, which may or may not be
> something you already know. This is what I do to send
> patches from my gmail account (change "name" and "acct" and
> "FILLTHISIN" and "patch-file" to suit yourself), and you
> could add --cc a few of us there also:
> >
> > git send-email --from 'name<acct@gmail.com>'
> \
> > --to linux-wireless@vger.kernel.org
> --to linville@tuxdriver.com
> \
> > --smtp-server smtp.gmail.com --smtp-server-port 465
> --smtp-user \ acct@gmail.com
> --smtp-pass FILLTHISIN --smtp-ssl patch-file
> >
> > You can do "man git-send-email" (all git man pages uses
> "git-something" to document the "git something" sub
> commands, with a dash between) to read about all the
> switches and what they are supposed to do.
<snipped>

> I fixed and tested your patch. With it, I certainly see the
> beacons and I was 
> able to use NetworkManager to connect once. However, I was
> never able to ping 
> from either end of the network to the other.

Do you need something manual set-up like "ifconfig wlan1 192.168.0.1" for one box and "ifconfig wlan1 192.168.0.2" for the other box in the IP layer to work? I haven't quite got my head around this one - how network manager agrees for each for go into a private tcp/ip network, given there are three(?) private ranges to use, and setting up host names, and what ip adresses to assign... and since there is no dns for a network of two, it would have to ping by ip address?

> Besides the mangling of the patch by your mailer, you had
> many problems with 
> spaces instead of tabs. Did you use scripts/checkpatch.pl to
> test for errors?

Hmm, probably try not to scare him away... Here is the definitive guide from Linus for submitting patches for the kernel in general:

http://linuxwireless.org/en/developers/Documentation/SubmittingPatches/sourcedoc

and here is one with information specific to wireless stuff:

http://linuxwireless.org/en/developers/Documentation/SubmittingPatches