From: Joe Perches <joe@perches.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Add iface name when calling WARN-ON.
Date: Sat, 10 Mar 2012 10:01:57 -0800 [thread overview]
Message-ID: <1331402517.14442.10.camel@joe2Laptop> (raw)
In-Reply-To: <4F5B8C66.4060808@candelatech.com>
On Sat, 2012-03-10 at 09:16 -0800, Ben Greear wrote:
[]
> >> diff --git a/net/mac80211/driver-ops.h b/net/mac80211/driver-ops.h
[]
> >> @@ -7,7 +7,11 @@
> >>
> >> static inline void check_sdata_in_driver(struct ieee80211_sub_if_data *sdata)
> >> {
> >> - WARN_ON(!(sdata->flags& IEEE80211_SDATA_IN_DRIVER));
> >> + if (unlikely(!(sdata->flags& IEEE80211_SDATA_IN_DRIVER))) {
> >> + printk(KERN_ERR "%s: Failed check-sdata-in-driver check, flags: 0x%x\n",
> >> + sdata->dev->name, sdata->flags);
Perhaps better as:
netdev_err(sdata->dev, "%s(): Failed check, flags: 0x%x\n",
__func__, sdata->flags);
prev parent reply other threads:[~2012-03-10 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 18:36 [PATCH] mac80211: Add iface name when calling WARN-ON greearb
2012-03-10 8:02 ` Johannes Berg
2012-03-10 17:16 ` Ben Greear
2012-03-10 18:01 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331402517.14442.10.camel@joe2Laptop \
--to=joe@perches.com \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox