Re: [PATCH] mac80211: Add iface name when calling WARN-ON.

[Ben Greear <greearb@candelatech.com>]

On 03/10/2012 12:02 AM, Johannes Berg wrote:
> On Fri, 2012-03-09 at 10:36 -0800, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> This lets the user know which interface has failed
>> the check_sdata_in_driver check.
>>
>> Signed-off-by: Ben Greear<greearb@candelatech.com>
>> ---
>> :100644 100644 e8960ae... e62e7c3... M	net/mac80211/driver-ops.h
>>   net/mac80211/driver-ops.h |    6 +++++-
>>   1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/mac80211/driver-ops.h b/net/mac80211/driver-ops.h
>> index e8960ae..e62e7c3 100644
>> --- a/net/mac80211/driver-ops.h
>> +++ b/net/mac80211/driver-ops.h
>> @@ -7,7 +7,11 @@
>>
>>   static inline void check_sdata_in_driver(struct ieee80211_sub_if_data *sdata)
>>   {
>> -	WARN_ON(!(sdata->flags&  IEEE80211_SDATA_IN_DRIVER));
>> +	if (unlikely(!(sdata->flags&  IEEE80211_SDATA_IN_DRIVER))) {
>> +		printk(KERN_ERR "%s:  Failed check-sdata-in-driver check, flags: 0x%x\n",
>> +		       sdata->dev->name, sdata->flags);
>> +		WARN_ON(1);
>> +	}
>
> How about WARN(!(...), ...) instead -- that way the message will be part
> of the warning too.
>
> johannes

Sure.  Also, should I maybe un-inline this thing since it is now a bit
bigger code wise?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com