Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] wl12xx: free ap keys only in ap mode
@ 2012-03-19  9:32 Eliad Peller
  2012-04-10 10:20 ` Luciano Coelho
  0 siblings, 1 reply; 2+ messages in thread
From: Eliad Peller @ 2012-03-19  9:32 UTC (permalink / raw)
  To: Luciano Coelho; +Cc: linux-wireless

The ap keys should be freed only when removing
ap role (otherwise, some arbitrary data might
get freed).

Signed-off-by: Eliad Peller <eliad@wizery.com>
---
 drivers/net/wireless/wl12xx/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 3900236..8cfbc95 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -2360,10 +2360,10 @@ deinit:
 		for (i = 0; i < CONF_TX_MAX_AC_COUNT; i++)
 			wl12xx_free_rate_policy(wl,
 						&wlvif->ap.ucast_rate_idx[i]);
+		wl1271_free_ap_keys(wl, wlvif);
 	}
 
 	wl12xx_tx_reset_wlvif(wl, wlvif);
-	wl1271_free_ap_keys(wl, wlvif);
 	if (wl->last_wlvif == wlvif)
 		wl->last_wlvif = NULL;
 	list_del(&wlvif->list);
-- 
1.7.6.401.g6a319


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wl12xx: free ap keys only in ap mode
  2012-03-19  9:32 [PATCH] wl12xx: free ap keys only in ap mode Eliad Peller
@ 2012-04-10 10:20 ` Luciano Coelho
  0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2012-04-10 10:20 UTC (permalink / raw)
  To: Eliad Peller; +Cc: linux-wireless

On Mon, 2012-03-19 at 11:32 +0200, Eliad Peller wrote: 
> The ap keys should be freed only when removing
> ap role (otherwise, some arbitrary data might
> get freed).
> 
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---

Pushed, thank you.

-- 
Cheers,
Luca.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-10 10:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-19  9:32 [PATCH] wl12xx: free ap keys only in ap mode Eliad Peller
2012-04-10 10:20 ` Luciano Coelho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox