Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Gary Morain <gmorain@chromium.org>
Cc: linux-wireless@vger.kernel.org, pstew@chromium.org
Subject: Re: [PATCH] CHROMIUMOS: mac80211: Increase retry attempts for nullfunc probes
Date: Mon, 21 May 2012 21:26:12 +0200	[thread overview]
Message-ID: <1337628372.11626.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120521190547.3E23A8061C@gary-pc2.mtv.corp.google.com> (sfid-20120521_211238_622219_A4B464A6)

On Fri, 2012-05-18 at 13:49 -0700, Gary Morain wrote:
> When a nullfunc probe fails for lack of an ACK, it is retried
> almost immediately.  The current setting of 2 retries completes
> in about 4 ms.  If an AP is off-channel scanning, this is not
> enough time for the AP to return to the operating channel and
> ACK the nullfunc.  As a result, the client disconnects when the
> AP is still there and operating.

AP is off-channel, scanning? It can't be unless it's a GO and then you
have GO powersave, right?

> -static int max_nullfunc_tries = 2;
> +static int max_nullfunc_tries = 100;

100? That seems insanely high compared to the other one.

johannes


  reply	other threads:[~2012-05-21 19:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 20:49 [PATCH] CHROMIUMOS: mac80211: Increase retry attempts for nullfunc probes Gary Morain
2012-05-21 19:26 ` Johannes Berg [this message]
     [not found]   ` <CADfcX6r=GuQh2kdC_OEX9fvfGjWXeGwFKGTfFWs-88nqgGNF_Q@mail.gmail.com>
2012-05-21 22:29     ` Gary Morain
2012-05-22  0:56       ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337628372.11626.0.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=gmorain@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pstew@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox