Linux wireless drivers development
 help / color / mirror / Atom feed
From: Gary Morain <gmorain@chromium.org>
To: linux-wireless@vger.kernel.org
Cc: pstew@chromium.org
Subject: [PATCH] CHROMIUMOS: mac80211: Increase retry attempts for nullfunc probes
Date: Fri, 18 May 2012 13:49:36 -0700	[thread overview]
Message-ID: <20120521190547.3E23A8061C@gary-pc2.mtv.corp.google.com> (raw)

When a nullfunc probe fails for lack of an ACK, it is retried
almost immediately.  The current setting of 2 retries completes
in about 4 ms.  If an AP is off-channel scanning, this is not
enough time for the AP to return to the operating channel and
ACK the nullfunc.  As a result, the client disconnects when the
AP is still there and operating.

Signed-off-by: Gary Morain <gmorain@chromium.org>
---
 net/mac80211/mlme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index dbd4bd9..dd1d901 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -36,7 +36,7 @@
 #define IEEE80211_ASSOC_TIMEOUT (HZ / 5)
 #define IEEE80211_ASSOC_MAX_TRIES 3
 
-static int max_nullfunc_tries = 2;
+static int max_nullfunc_tries = 100;
 module_param(max_nullfunc_tries, int, 0644);
 MODULE_PARM_DESC(max_nullfunc_tries,
 		 "Maximum nullfunc tx tries before disconnecting (reason 4).");
-- 
1.7.7.3


             reply	other threads:[~2012-05-21 19:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 20:49 Gary Morain [this message]
2012-05-21 19:26 ` [PATCH] CHROMIUMOS: mac80211: Increase retry attempts for nullfunc probes Johannes Berg
     [not found]   ` <CADfcX6r=GuQh2kdC_OEX9fvfGjWXeGwFKGTfFWs-88nqgGNF_Q@mail.gmail.com>
2012-05-21 22:29     ` Gary Morain
2012-05-22  0:56       ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120521190547.3E23A8061C@gary-pc2.mtv.corp.google.com \
    --to=gmorain@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pstew@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox