From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
david.spinadel@intel.com
Subject: Re: [PATCH 3.5] mac80211: stop polling in disassociation
Date: Wed, 13 Jun 2012 10:08:16 +0200 [thread overview]
Message-ID: <1339574896.4519.8.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAB3XZEf++ayd3s1v61Z9BAeDEFVcehddaAPVabenm25Fhf_6Rw@mail.gmail.com> (sfid-20120613_100002_998594_9796B48B)
On Wed, 2012-06-13 at 11:00 +0300, Eliad Peller wrote:
> > @@ -1329,6 +1329,8 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
> > u32 changed = 0;
> > u8 bssid[ETH_ALEN];
> >
> > + ieee80211_stop_poll(sdata);
> > +
> > ASSERT_MGD_MTX(ifmgd);
>
> it doesn't matter much, but maybe better add the call after the
> function "prologue" (lockdep, WARN_ONs, ...)?
I think we shouldn't do it after the warnings since those affect the
control flow. OTOH, they should never happen ...
johannes
next prev parent reply other threads:[~2012-06-13 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 6:51 [PATCH 3.5] mac80211: stop polling in disassociation Johannes Berg
2012-06-13 8:00 ` Eliad Peller
2012-06-13 8:08 ` Johannes Berg [this message]
2012-06-13 8:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339574896.4519.8.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=david.spinadel@intel.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox