From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: Joe Perches <joe@perches.com>,
linux-wireless@vger.kernel.org, bzhao@marvell.com
Subject: Re: [PATCH] mwifiex: Using %*phD instead of print_hex_dump_bytes
Date: Fri, 05 Oct 2012 13:19:58 +0300 [thread overview]
Message-ID: <1349432398.10584.31.camel@smile> (raw)
In-Reply-To: <20121005100719.GD12229@aemeltch-MOBL1>
On Fri, 2012-10-05 at 13:07 +0300, Andrei Emeltchenko wrote:
> On Fri, Oct 05, 2012 at 10:00:28AM +0300, Andy Shevchenko wrote:
> > And one finding more: buffers are defined as u16. I'm afraid the both
> > previous and proposed versions are printing something interesting, like
> > only half of the defined data.
>
> The patch only changes printing format. The other logical change would
> come better in other patch, maybe Bing could comment here.
What about to fix logic first and then to substitute the
print_hex_dump_bytes() calls?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-10-05 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 9:16 [PATCH] mwifiex: Using %*phD instead of print_hex_dump_bytes Andrei Emeltchenko
2012-10-04 16:32 ` Joe Perches
2012-10-05 6:53 ` Andy Shevchenko
2012-10-05 7:00 ` Andy Shevchenko
2012-10-05 10:07 ` Andrei Emeltchenko
2012-10-05 10:19 ` Andy Shevchenko [this message]
2012-10-05 12:58 ` Andrei Emeltchenko
2012-10-05 19:43 ` Bing Zhao
2012-10-05 10:11 ` Andrei Emeltchenko
2012-10-05 10:18 ` Andy Shevchenko
2012-10-05 10:27 ` Andrei Emeltchenko
2012-10-05 19:35 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349432398.10584.31.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=bzhao@marvell.com \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).