From: Johannes Berg <johannes@sipsolutions.net>
To: chaitanyatk@posedge.com
Cc: linux-wireless@vger.kernel.org, maheshp@posedge.com
Subject: Re: [RFC] mac80211: Add support for Tx-AMSDU viz debugfs.
Date: Thu, 07 Feb 2013 09:20:30 +0100 [thread overview]
Message-ID: <1360225230.8038.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <7384f4ddc838247a0f467708d66baa8c@posedge.com>
On Thu, 2013-02-07 at 00:01 -0800, chaitanyatk@posedge.com wrote:
> @@ -470,6 +470,7 @@ enum mac80211_tx_control_flags {
> IEEE80211_TX_STATUS_EOSP = BIT(28),
> IEEE80211_TX_CTL_USE_MINRATE = BIT(29),
> IEEE80211_TX_CTL_DONTFRAG = BIT(30),
> + IEEE80211_TX_CTL_AMSDU = BIT(31),
Hmm. I'm not exactly happy with using (one of) the last control flag for
a pure debug facility.
> +++ b/net/mac80211/ieee80211_i.h
> @@ -402,7 +402,6 @@ struct ieee80211_mgd_assoc_data {
> bool have_beacon;
> bool sent_assoc;
> bool synced;
> -
All those spurious whitespace changes just make the patch appear
longer ... :)
johannes
next prev parent reply other threads:[~2013-02-07 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 8:01 [RFC] mac80211: Add support for Tx-AMSDU viz debugfs chaitanyatk
2013-02-07 8:20 ` Johannes Berg [this message]
2013-02-07 9:19 ` Krishna Chaitanya
2013-02-07 9:23 ` Johannes Berg
2013-02-07 9:30 ` Krishna Chaitanya
2013-02-07 14:03 ` Felix Fietkau
2013-02-07 14:17 ` Johannes Berg
2013-02-07 14:57 ` Krishna Chaitanya
2013-02-07 15:18 ` Felix Fietkau
2013-02-07 15:27 ` Johannes Berg
2013-02-11 7:54 ` Krishna Chaitanya
2013-02-11 8:46 ` Johannes Berg
2013-02-11 9:28 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360225230.8038.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanyatk@posedge.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maheshp@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox