From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: chaitanyatk@posedge.com, linux-wireless@vger.kernel.org,
maheshp@posedge.com
Subject: Re: [RFC] mac80211: Add support for Tx-AMSDU viz debugfs.
Date: Thu, 07 Feb 2013 10:23:11 +0100 [thread overview]
Message-ID: <1360228991.8038.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CABPxzYLnWjxtN_c1sFXpA3Ye9ZNvQgV1dU0z=59j0WqgM-rUpg@mail.gmail.com> (sfid-20130207_102010_516659_782CEA2D)
On Thu, 2013-02-07 at 14:49 +0530, Krishna Chaitanya wrote:
> On Thu, Feb 7, 2013 at 1:50 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Thu, 2013-02-07 at 00:01 -0800, chaitanyatk@posedge.com wrote:
> >
>
> > Hmm. I'm not exactly happy with using (one of) the last control flag for
> > a pure debug facility.
> >
> Hmm...initially i tried to add qos header in the debugfs itself but to avoid
> code redundancy went with the TX_CTL. But in either case we need some kind
> of flag to skip adding the qos header by mac80211 (or) to set the AMSDU
> bit in the qos control header.
I guess the question is whether we really need this code in the tree at
all? It seems like a (relatively) obscure debug feature for which I'm
not sure we should touch the TX fastpath?
johannes
next prev parent reply other threads:[~2013-02-07 9:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 8:01 [RFC] mac80211: Add support for Tx-AMSDU viz debugfs chaitanyatk
2013-02-07 8:20 ` Johannes Berg
2013-02-07 9:19 ` Krishna Chaitanya
2013-02-07 9:23 ` Johannes Berg [this message]
2013-02-07 9:30 ` Krishna Chaitanya
2013-02-07 14:03 ` Felix Fietkau
2013-02-07 14:17 ` Johannes Berg
2013-02-07 14:57 ` Krishna Chaitanya
2013-02-07 15:18 ` Felix Fietkau
2013-02-07 15:27 ` Johannes Berg
2013-02-11 7:54 ` Krishna Chaitanya
2013-02-11 8:46 ` Johannes Berg
2013-02-11 9:28 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360228991.8038.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=chaitanyatk@posedge.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maheshp@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox