From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/3] mac80211/minstrel_ht: add support for using CCK rates
Date: Mon, 11 Feb 2013 15:31:28 +0100 [thread overview]
Message-ID: <1360593088.8738.31.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <5118FBC9.7000801@openwrt.org>
On Mon, 2013-02-11 at 15:10 +0100, Felix Fietkau wrote:
> On 2013-02-11 2:57 PM, Christian Lamparter wrote:
> > On Monday, February 11, 2013 02:36:05 PM Felix Fietkau wrote:
> >> When MCS rates start to get bad in 2.4 GHz because of long range or
> >> strong interference, CCK rates can be a lot more robust.
> >>
> >> This patch adds a pseudo MCS group containing CCK rates (long preamble
> >> in the lower 4 slots, short preamble in the upper slots).
> >>
> >> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> >> ---
> >> static void
> >> +minstrel_ht_update_cck(struct minstrel_priv *mp, struct minstrel_ht_sta *mi,
> >> + struct ieee80211_supported_band *sband,
> >> + struct ieee80211_sta *sta)
> >> +{
> >> + int i;
> >> +
> >> + if (sband->band != IEEE80211_BAND_2GHZ)
> >> + return;
> >> +
> >> + mi->cck_supported = 0;
> >> + mi->cck_supported_short = 0;
> >> + for (i = 0; i < 4; i++) {
> >> + if (!rate_supported(sta, sband->band, mp->cck_rates[i]))
> >> + continue;
> >
> > Don't we need to check if the receiver (and the minstrel_ht sender)
> > supports IEEE80211_HT_CAP_DSSSCCK40 when the phy is in HT40+/- mode?
> I don't think this should be handled in the rate control modules, when
> mac80211 can easily handle that through the supported rates set (which
> seems to be the intention behind this flag in the standard as well).
Patches welcome. This corner of the spec doesn't seem to be implemented
at all :)
johannes
next prev parent reply other threads:[~2013-02-11 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 13:36 [PATCH v2 1/3] mac80211/minstrel_ht: show the number of retries for each rate in debugfs Felix Fietkau
2013-02-11 13:36 ` [PATCH v2 2/3] mac80211/minstrel_ht: remove the sampling bypass check for the lowest rate Felix Fietkau
2013-02-11 13:36 ` [PATCH v2 3/3] mac80211/minstrel_ht: add support for using CCK rates Felix Fietkau
2013-02-11 13:57 ` Christian Lamparter
2013-02-11 14:10 ` Felix Fietkau
2013-02-11 14:31 ` Johannes Berg [this message]
2013-02-11 21:51 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360593088.8738.31.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox