From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/3] mac80211/minstrel_ht: add support for using CCK rates
Date: Mon, 11 Feb 2013 22:51:40 +0100 [thread overview]
Message-ID: <1360619500.8738.53.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1360589765-58642-3-git-send-email-nbd@openwrt.org>
Applied patches 1 and 2 but this one had too many smatch complaints:
> #define CCK_GROUP \
> { \
> .streams = 0, \
> .duration = { \
> CCK_DURATION_LIST(false), \
> CCK_DURATION_LIST(true) \
> } \
> }
This seems to have caused smatch to complain, because after having
#define MCS_GROUP(_streams, _sgi, _ht40) \
[GROUP_IDX(_streams, _sgi, _ht40)] = { \
it couldn't prove that the CCK went into slot 12. Are you sure they go
there for sure, with the different initialization?
> +struct minstrel_rate_stats *
> +minstrel_ht_get_stats(struct minstrel_priv *mp, struct minstrel_ht_sta *mi,
> + struct ieee80211_tx_rate *rate)
> +{
> + int group, idx;
> +
> + if (rate->flags & IEEE80211_TX_RC_MCS) {
> + group = minstrel_ht_get_group_idx(rate);
> + idx = rate->idx % MCS_GROUP_RATES;
> + } else {
> + group = MINSTREL_CCK_GROUP;
> +
> + for (idx = 0; idx <= ARRAY_SIZE(mp->cck_rates); idx++)
should be < rather than <=?
> + if (rate->flags & IEEE80211_TX_RC_MCS);
> + return true;
ho humm ...
johannes
prev parent reply other threads:[~2013-02-11 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 13:36 [PATCH v2 1/3] mac80211/minstrel_ht: show the number of retries for each rate in debugfs Felix Fietkau
2013-02-11 13:36 ` [PATCH v2 2/3] mac80211/minstrel_ht: remove the sampling bypass check for the lowest rate Felix Fietkau
2013-02-11 13:36 ` [PATCH v2 3/3] mac80211/minstrel_ht: add support for using CCK rates Felix Fietkau
2013-02-11 13:57 ` Christian Lamparter
2013-02-11 14:10 ` Felix Fietkau
2013-02-11 14:31 ` Johannes Berg
2013-02-11 21:51 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360619500.8738.53.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox