From: Johannes Berg <johannes@sipsolutions.net>
To: michael-dev <michael-dev@fami-braun.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
projekt-wlan@fem.tu-ilmenau.de
Subject: Re: [PATCHv2 1/1] mac80211: fix WPA with VLAN on AP side with ps-sta
Date: Tue, 12 Feb 2013 18:45:39 +0100 [thread overview]
Message-ID: <1360691139.29913.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <c35750825fc4c49d07d9d6e232b46623@fami-braun.de> (sfid-20130212_184310_653774_8CDBA907)
On Tue, 2013-02-12 at 18:42 +0100, michael-dev wrote:
> >> - if (!ieee80211_tx_prepare(sdata, &tx, skb))
> >> + frame_sdata = IEEE80211_DEV_TO_SUB_IF(skb->dev);
> >> + if (!ieee80211_tx_prepare(frame_sdata, &tx, skb))
> >> break;
> >
> > This can now crash the machine.
>
> why? when?
There's no guarantee that the VLAN interface isn't destroyed while the
frame is stuck on the buffer queue.
> What would be a better approach?
This is probably fine, but incomplete -- frames for a VLAN need to be
removed from the PS queue when it goes down.
johannes
prev parent reply other threads:[~2013-02-12 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 16:37 [PATCHv2 0/1] mac80211: fix VLAN support on AP with ps-sta Michael Braun
2013-02-12 16:37 ` [PATCHv2 1/1] mac80211: fix WPA with VLAN on AP side " Michael Braun
2013-02-12 16:38 ` Johannes Berg
2013-02-12 16:40 ` Johannes Berg
2013-02-12 17:42 ` michael-dev
2013-02-12 17:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360691139.29913.8.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=michael-dev@fami-braun.de \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox