Linux wireless drivers development
 help / color / mirror / Atom feed
From: michael-dev <michael-dev@fami-braun.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
	<projekt-wlan@fem.tu-ilmenau.de>
Subject: Re: [PATCHv2 1/1] mac80211: fix WPA with VLAN on AP side with ps-sta
Date: Tue, 12 Feb 2013 18:42:50 +0100	[thread overview]
Message-ID: <c35750825fc4c49d07d9d6e232b46623@fami-braun.de> (raw)
In-Reply-To: <1360687114.29913.5.camel@jlt4.sipsolutions.net>

Hi,

thanks for reviewing.

Am 12.02.2013 17:38, schrieb Johannes Berg:
> [use sdata instead of frame_sdata]

can be done.

>> -		if (!ieee80211_tx_prepare(sdata, &tx, skb))
>> +		frame_sdata = IEEE80211_DEV_TO_SUB_IF(skb->dev);
>> +		if (!ieee80211_tx_prepare(frame_sdata, &tx, skb))
>>  			break;
> 
> This can now crash the machine.

why? when?
What would be a better approach?

Regards,
  M. Braun


  parent reply	other threads:[~2013-02-12 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 16:37 [PATCHv2 0/1] mac80211: fix VLAN support on AP with ps-sta Michael Braun
2013-02-12 16:37 ` [PATCHv2 1/1] mac80211: fix WPA with VLAN on AP side " Michael Braun
2013-02-12 16:38   ` Johannes Berg
2013-02-12 16:40     ` Johannes Berg
2013-02-12 17:42     ` michael-dev [this message]
2013-02-12 17:45       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c35750825fc4c49d07d9d6e232b46623@fami-braun.de \
    --to=michael-dev@fami-braun.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=projekt-wlan@fem.tu-ilmenau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox