Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: linux-wireless@vger.kernel.org,
	Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
	Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [RFC 0/4] add master channel switch announcement support
Date: Mon, 13 May 2013 12:09:38 +0200	[thread overview]
Message-ID: <1368439778.8300.20.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1367867635-3459-1-git-send-email-siwu@hrz.tu-chemnitz.de>

On Mon, 2013-05-06 at 21:13 +0200, Simon Wunderlich wrote:
> This is an early RFC of a possible channel switch announcement infrastructure.
> It adds CSA/ECSA handling support for AP. This is required for DFS operation
> (e.g. Wi-Fi Alliance requires this for 802.11h certification). This will also
> be required for IBSS-DFS later.
> 
> I'd like to discuss if this design approach is going in the right direction.
> What is currently working:
> 
>  * channels are announced by adding IEs (CSA and Extended CSA) in beacons
>  * after some (configurable) time, the channel is switched
>  * with the channel switch, CSA/ECSA IEs are removed and channel information
>    is updated.
>  * Userspace calls a new command NL80211_CMD_CHANNEL_SWITCH along with channel info
>    (freq + width), whether traffic should be blocked and timing information
>  * it currently works for me [TM] on my ath9k based machine

I don't really like your approach of building all the IEs in the kernel.
There are some things, like the country-after-switch in the CSA wrapper
(introduced in 11ac), that would be really awkward this way.

>  * We already have NL80211_CMD_CH_SWITCH_NOTIFY which is only used for notification.
>    Maybe we can rename that and re-use it instead of adding a new command
>    NL80211_CMD_CHANNEL_SWITCH?

Sure, I don't really care though.

>  * Changes from HT20/NOHT to HT20/NOHT are handled with normal Channel Switch
>    Announcements, everything else (for 40 MHz) is done with Extended Channel Switch
>    Announcements. As far as I read the spec, we can't  use the secondary channel
>    offset IE in beacons, but maybe I'm wrong here?

No, you're right and I was wrong :-)

>  * could other drivers (next to ath9k) work with this API?

Probably not easily. Any TI folks reading this?


Anyway I think it'd be better to try to provide
 (a) the "during-switch IEs", maybe with an offset to the counter so
mac80211,
     driver or the device itself can count down
 (b) the "after-switch beacon" IEs (and maybe probe response for
offload)

johannes


  parent reply	other threads:[~2013-05-13 10:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 19:13 [RFC 0/4] add master channel switch announcement support Simon Wunderlich
2013-05-06 19:13 ` [RFC 1/4] cfg80211: add chandef to operating class conversion Simon Wunderlich
2013-05-06 19:13 ` [RFC 2/4] nl80211/cfg80211: add channel switch command Simon Wunderlich
2013-05-06 19:13 ` [RFC 3/4] mac80211: add channel switch command and beacon callbacks Simon Wunderlich
2013-05-06 19:13 ` [RFC 4/4] ath9k: enable CSA functionality in ath9k Simon Wunderlich
2013-05-13 10:09 ` Johannes Berg [this message]
2013-05-14  9:27   ` [RFC 0/4] add master channel switch announcement support Simon Wunderlich
2013-05-28 10:43     ` Simon Wunderlich
2013-06-11 12:31     ` Johannes Berg
2013-06-11 14:18       ` Simon Wunderlich
2013-06-18 14:01         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368439778.8300.20.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathias.kretschmer@fokus.fraunhofer.de \
    --cc=simon.wunderlich@s2003.tu-chemnitz.de \
    --cc=siwu@hrz.tu-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox