From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [RFC 0/4] add master channel switch announcement support
Date: Tue, 28 May 2013 12:43:57 +0200 [thread overview]
Message-ID: <20130528104357.GB13489@pandem0nium> (raw)
In-Reply-To: <20130514092734.GA16426@pandem0nium>
[-- Attachment #1: Type: text/plain, Size: 2339 bytes --]
Hey,
On Tue, May 14, 2013 at 11:27:34AM +0200, Simon Wunderlich wrote:
> > > [....]
> >
> > I don't really like your approach of building all the IEs in the kernel.
> > There are some things, like the country-after-switch in the CSA wrapper
> > (introduced in 11ac), that would be really awkward this way.
>
> Hmm ... OK. I have not checked 802.11ac yet (actually I don't have access to the
> drafts anyway). So what we have to expect is changing the country after the switch,
> or also other new things?
>
> > > * We already have NL80211_CMD_CH_SWITCH_NOTIFY which is only used for notification.
> > > Maybe we can rename that and re-use it instead of adding a new command
> > > NL80211_CMD_CHANNEL_SWITCH?
> >
> > Sure, I don't really care though.
> >
> OK, will try to merge that then. Seems cleaner than having multiple channel switch
> commands in the API.
>
> > > * could other drivers (next to ath9k) work with this API?
> >
> > Probably not easily. Any TI folks reading this?
>
> I was thinking about adding another callback function or option for that for drivers
> who do the channel switch internally. Then we would only need mac80211 to adapt.
>
> Would that help, or what would be problematic?
> >
> >
> > Anyway I think it'd be better to try to provide
> > (a) the "during-switch IEs", maybe with an offset to the counter so
> > mac80211,
> > driver or the device itself can count down
> > (b) the "after-switch beacon" IEs (and maybe probe response for
> o> offload)
>
> Yeah, that would be an alternative. I've been inspired by IEEE 802.11-2012/6.3.17
> (MLME-CHANNELSWITCH) originally. :)
> I think your suggestion is good for AP where we control the beacon. For IBSS it
> would be a little different: when a channel switch is triggered, userspace does
> not know the beacon (and will not set it). Therefore, we could only accept the
> change IEs and skip the "after-switch-beacon" IEs (these would be re-generated
> internally) in IBSS mode. I guess it would be similar for mesh.
>
> What do you think?
I'd like to bump this issue again - if we agree on that this solution could work
for IBSS and possibly other modes I'd like to prepare the patchset implementing that.
This is required for IBSS-DFS later after all ...
Thanks,
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-05-28 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 19:13 [RFC 0/4] add master channel switch announcement support Simon Wunderlich
2013-05-06 19:13 ` [RFC 1/4] cfg80211: add chandef to operating class conversion Simon Wunderlich
2013-05-06 19:13 ` [RFC 2/4] nl80211/cfg80211: add channel switch command Simon Wunderlich
2013-05-06 19:13 ` [RFC 3/4] mac80211: add channel switch command and beacon callbacks Simon Wunderlich
2013-05-06 19:13 ` [RFC 4/4] ath9k: enable CSA functionality in ath9k Simon Wunderlich
2013-05-13 10:09 ` [RFC 0/4] add master channel switch announcement support Johannes Berg
2013-05-14 9:27 ` Simon Wunderlich
2013-05-28 10:43 ` Simon Wunderlich [this message]
2013-06-11 12:31 ` Johannes Berg
2013-06-11 14:18 ` Simon Wunderlich
2013-06-18 14:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528104357.GB13489@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox