Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame
@ 2013-07-02  2:18 Harvey Yang
  2013-07-02  5:33 ` Bing Zhao
  0 siblings, 1 reply; 2+ messages in thread
From: Harvey Yang @ 2013-07-02  2:18 UTC (permalink / raw)
  To: Bing Zhao, linux-wireless; +Cc: linux-kernel, Huawei Yang

From: Huawei Yang <harvey.huawei.yang@gmail.com>

In function 'mwifiex_write_data_complete' it need tx info to find
the mwifiex_private to updates statistics and wake up tx queues.
Or we may trigger tx queues timeout when transmitting lots of mgmt
frames.

Signed-off-by: Huawei Yang <harvey.huawei.yang@gmail.com>
---
 drivers/net/wireless/mwifiex/cfg80211.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
index e42b266..b4e2538 100644
--- a/drivers/net/wireless/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/mwifiex/cfg80211.c
@@ -186,6 +186,7 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
 	struct sk_buff *skb;
 	u16 pkt_len;
 	const struct ieee80211_mgmt *mgmt;
+	struct mwifiex_txinfo *tx_info;
 	struct mwifiex_private *priv = mwifiex_netdev_get_priv(wdev->netdev);
 
 	if (!buf || !len) {
@@ -212,6 +213,10 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
 		wiphy_err(wiphy, "allocate skb failed for management frame\n");
 		return -ENOMEM;
 	}
+	
+	tx_info = MWIFIEX_SKB_TXCB(skb);
+	tx_info->bss_num = priv->bss_num;
+	tx_info->bss_type = priv->bss_type;
 
 	mwifiex_form_mgmt_frame(skb, buf, len);
 	mwifiex_queue_tx_pkt(priv, skb);
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame
  2013-07-02  2:18 [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame Harvey Yang
@ 2013-07-02  5:33 ` Bing Zhao
  0 siblings, 0 replies; 2+ messages in thread
From: Bing Zhao @ 2013-07-02  5:33 UTC (permalink / raw)
  To: Harvey Yang, linux-wireless@vger.kernel.org; +Cc: linux-kernel@vger.kernel.org

Hi Harvey,

> From: Huawei Yang <harvey.huawei.yang@gmail.com>
> 
> In function 'mwifiex_write_data_complete' it need tx info to find the
> mwifiex_private to updates statistics and wake up tx queues.
> Or we may trigger tx queues timeout when transmitting lots of mgmt frames.
> 
> Signed-off-by: Huawei Yang <harvey.huawei.yang@gmail.com>
> ---
>  drivers/net/wireless/mwifiex/cfg80211.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/wireless/mwifiex/cfg80211.c
> b/drivers/net/wireless/mwifiex/cfg80211.c
> index e42b266..b4e2538 100644
> --- a/drivers/net/wireless/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/mwifiex/cfg80211.c
> @@ -186,6 +186,7 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy,
> struct wireless_dev *wdev,
>  	struct sk_buff *skb;
>  	u16 pkt_len;
>  	const struct ieee80211_mgmt *mgmt;
> +	struct mwifiex_txinfo *tx_info;
>  	struct mwifiex_private *priv = mwifiex_netdev_get_priv(wdev-
> >netdev);
> 
>  	if (!buf || !len) {
> @@ -212,6 +213,10 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy,
> struct wireless_dev *wdev,
>  		wiphy_err(wiphy, "allocate skb failed for management
> frame\n");
>  		return -ENOMEM;
>  	}
> +

Here checkpatch.pl script reports whitespace damaged error.
I can fix it in my local tree and resend v3 to John after the 3.11 merge window.

Thanks,
Bing

> +	tx_info = MWIFIEX_SKB_TXCB(skb);
> +	tx_info->bss_num = priv->bss_num;
> +	tx_info->bss_type = priv->bss_type;
> 
>  	mwifiex_form_mgmt_frame(skb, buf, len);
>  	mwifiex_queue_tx_pkt(priv, skb);
> --
> 1.7.10.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-02  5:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-02  2:18 [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame Harvey Yang
2013-07-02  5:33 ` Bing Zhao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox