* [PATCH] mac80211: Handle zero RTS threshold
@ 2013-07-05 5:45 Sujith Manoharan
2013-07-05 7:15 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Sujith Manoharan @ 2013-07-05 5:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
The spec says:
"Setting this attribute to 0 has the effect of turning on the RTS/CTS
handshake for all frames of Data or Management type transmitted by this
STA."
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
net/mac80211/tx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 4105d0c..50c7309 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -651,7 +651,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
tx->sdata->vif.type == NL80211_IFTYPE_ADHOC);
/* set up RTS protection if desired */
- if (len > tx->local->hw.wiphy->rts_threshold) {
+ if (!tx->local->hw.wiphy->rts_threshold ||
+ (len > tx->local->hw.wiphy->rts_threshold)) {
txrc.rts = true;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: Handle zero RTS threshold
2013-07-05 5:45 [PATCH] mac80211: Handle zero RTS threshold Sujith Manoharan
@ 2013-07-05 7:15 ` Johannes Berg
2013-07-05 8:51 ` Sujith Manoharan
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2013-07-05 7:15 UTC (permalink / raw)
To: Sujith Manoharan; +Cc: linux-wireless
On Fri, 2013-07-05 at 11:15 +0530, Sujith Manoharan wrote:
> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> The spec says:
>
> "Setting this attribute to 0 has the effect of turning on the RTS/CTS
> handshake for all frames of Data or Management type transmitted by this
> STA."
Maybe we should set it to 0xffffffff in cfg80211 to make it simpler for
drivers?
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: Handle zero RTS threshold
2013-07-05 7:15 ` Johannes Berg
@ 2013-07-05 8:51 ` Sujith Manoharan
0 siblings, 0 replies; 3+ messages in thread
From: Sujith Manoharan @ 2013-07-05 8:51 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Johannes Berg wrote:
> Maybe we should set it to 0xffffffff in cfg80211 to make it simpler for
> drivers?
The patch is broken, please disregard it.
Sujith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-05 8:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-05 5:45 [PATCH] mac80211: Handle zero RTS threshold Sujith Manoharan
2013-07-05 7:15 ` Johannes Berg
2013-07-05 8:51 ` Sujith Manoharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox