[PATCH] iw: correction in coalesce condition display message

[PATCH] iw: correction in coalesce condition display message

[Bing Zhao]

From: Amitkumar Karwar <akarwar@marvell.com>

NL80211_COALESCE_CONDITION_MATCH is 0 and
NL80211_COALESCE_CONDITION_NO_MATCH is 1.
Hence this change is required

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
---
 coalesce.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/coalesce.c b/coalesce.c
index 22d1534..0239915 100644
--- a/coalesce.c
+++ b/coalesce.c
@@ -175,7 +175,7 @@ COMMAND(coalesce, enable, "<config-file>",
 	"  patterns=<[offset1+]<pattern1>,<[offset2+]<pattern2>,...>\n"
 	"  ...\n"
 	"delay: maximum coalescing delay in msec.\n"
-	"condition: 0/1 i.e. 'not match'/'match' the patterns\n"
+	"condition: 1/0 i.e. 'not match'/'match' the patterns\n"
 	"patterns: each pattern is given as a bytestring with '-' in\n"
 	"places where any byte may be present, e.g. 00:11:22:-:44 will\n"
 	"match 00:11:22:33:44 and 00:11:22:33:ff:44 etc. Offset and\n"
@@ -224,9 +224,9 @@ static int print_coalesce_handler(struct nl_msg *msg, void *arg)
 
 		printf("Rule - max coalescing delay: %dmsec condition:", delay);
 		if (condition)
-			printf("match\n");
-		else
 			printf("not match\n");
+		else
+			printf("match\n");
 
 		if (ruleattr[NL80211_ATTR_COALESCE_RULE_PKT_PATTERN]) {
 			nla_for_each_nested(pattern,
-- 
1.8.0

Re: [PATCH] iw: correction in coalesce condition display message

[Johannes Berg]

On Mon, 2013-08-05 at 15:06 -0700, Bing Zhao wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
> 
> NL80211_COALESCE_CONDITION_MATCH is 0 and
> NL80211_COALESCE_CONDITION_NO_MATCH is 1.
> Hence this change is required

Pretty weird, but ok. Maybe asking to give "match" or "no-match" in the
file would have been better.

Applied.

johannes