Re: [PATCH 5/6] ath6kl: remove a warning on a macro

[Joe Perches <joe@perches.com>]

On Sun, 2014-03-09 at 09:10 +0200, Kalle Valo wrote:
> Hi Joe,

Hi Kalle.

> I would need help with this checkpatch warning:

No idea what the warning is.

> > --- a/drivers/net/wireless/ath/ath6kl/debug.c
> > +++ b/drivers/net/wireless/ath/ath6kl/debug.c
> > @@ -798,12 +798,10 @@ static ssize_t ath6kl_endpoint_stats_read(struct file *file,
> >  		return -ENOMEM;
> >  
> >  #define EPSTAT(name)							\
> > -	do {								\
> > -		len = print_endpoint_stat(target, buf, buf_len, len,	\
> > -					  offsetof(struct htc_endpoint_stats, \
> > -						   name),		\
> > -					  #name);			\
> > -	} while (0)
> > +	(len = print_endpoint_stat(target, buf, buf_len, len,		\
> > +				   offsetof(struct htc_endpoint_stats,	\
> > +					    name),			\
> > +				   #name))
> 
> I wasn't quite able to figure out what is the preferred style here. I
> don't see how the () style is any better, but checkpatch didn't complain
> at least.

No idea what the preferred style is, but
I'd probably change the #define to

#define EPSTAT(name)							\
	print_endpoint_stat(target, buf, buf_len, len,			\
			    offsetof(struct htc_endpoint_stats, name),	\
			    #name)

and the uses to

	len = EPSTAT(whatever);