From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath6kl@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/6] ath6kl: remove unnecessary line continuations
Date: Sun, 09 Mar 2014 14:15:33 -0700 [thread overview]
Message-ID: <1394399733.6972.47.camel@joe-AO722> (raw)
In-Reply-To: <20140309065729.10793.45052.stgit@x230>
On Sun, 2014-03-09 at 08:57 +0200, Kalle Valo wrote:
> Fixes checkpatch warning:
> WARNING: Avoid unnecessary line continuations
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
[]
> diff --git a/drivers/net/wireless/ath/ath6kl/core.c b/drivers/net/wireless/ath/ath6kl/core.c
[]
> @@ -45,8 +45,9 @@ module_param(testmode, uint, 0644);
> module_param(recovery_enable, uint, 0644);
> module_param(heart_beat_poll, uint, 0644);
> MODULE_PARM_DESC(recovery_enable, "Enable recovery from firmware error");
> -MODULE_PARM_DESC(heart_beat_poll, "Enable fw error detection periodic" \
> - "polling. This also specifies the polling interval in" \
> +MODULE_PARM_DESC(heart_beat_poll,
> + "Enable fw error detection periodic"
> + "polling. This also specifies the polling interval in"
> "msecs. Set reocvery_enable for this to be effective");
Couple things:
o There's a missing space between periodic and polling
o There's a typo of recovery
My suggestion would be to use:
MODULE_PARM_DESC(heart_beat_poll,
"Enable fw error detection periodic polling in msecs - Also set recovery_enable for this to be effective");
next prev parent reply other threads:[~2014-03-09 21:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 6:57 [PATCH 0/6] ath6kl: fixing new checkpatch warnings Kalle Valo
2014-03-09 6:57 ` [PATCH 1/6] ath6kl: fix blank lines before and after braces Kalle Valo
2014-03-09 6:57 ` [PATCH 2/6] ath6kl: use braces on both arms of if statement Kalle Valo
2014-03-09 21:42 ` Joe Perches
2014-03-10 17:23 ` Kalle Valo
2014-03-12 8:47 ` Jones Desougi
2014-03-12 8:52 ` Kalle Valo
2014-03-12 14:11 ` Joe Perches
2014-03-09 6:57 ` [PATCH 3/6] ath6kl: remove spaces before semicolon Kalle Valo
2014-03-09 6:57 ` [PATCH 4/6] ath6kl: remove unnecessary line continuations Kalle Valo
2014-03-09 21:15 ` Joe Perches [this message]
2014-03-10 17:26 ` Kalle Valo
2014-03-09 6:57 ` [PATCH 5/6] ath6kl: remove a warning on a macro Kalle Valo
2014-03-09 7:10 ` Kalle Valo
2014-03-09 7:20 ` Joe Perches
2014-03-09 7:44 ` Joe Perches
2014-03-10 17:29 ` Kalle Valo
2014-03-10 20:03 ` Joe Perches
2014-03-09 6:57 ` [PATCH 6/6] ath6kl: update Kconfig descriptions Kalle Valo
2014-03-13 5:48 ` [PATCH 0/6] ath6kl: fixing new checkpatch warnings Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394399733.6972.47.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ath6kl@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox