* [PATCH] rsi: Add pr_fmt,__printf, fix format & arg mismatch
@ 2014-03-19 0:59 Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2014-03-19 0:59 UTC (permalink / raw)
To: Fariya Fatima; +Cc: John W. Linville, linux-wireless, netdev
Emit a prefix for the rsi_dbg messages.
Fix the format and argument mismatch and add
__printf(2, 3) to try to avoid more.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/wireless/rsi/rsi_91x_main.c | 2 ++
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 3 ++-
drivers/net/wireless/rsi/rsi_main.h | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_main.c b/drivers/net/wireless/rsi/rsi_91x_main.c
index 7367be4..8810862 100644
--- a/drivers/net/wireless/rsi/rsi_91x_main.c
+++ b/drivers/net/wireless/rsi/rsi_91x_main.c
@@ -14,6 +14,8 @@
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/module.h>
#include <linux/firmware.h>
#include "rsi_mgmt.h"
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index f09c72e..ef37d4b 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -393,7 +393,8 @@ static int rsi_mgmt_pkt_to_core(struct rsi_common *common,
msg_len -= pad_bytes;
if ((msg_len <= 0) || (!msg)) {
- rsi_dbg(MGMT_RX_ZONE, "Invalid rx msg of len = %d\n",
+ rsi_dbg(MGMT_RX_ZONE,
+ "%s: Invalid rx msg of len = %d\n",
__func__, msg_len);
return -EINVAL;
}
diff --git a/drivers/net/wireless/rsi/rsi_main.h b/drivers/net/wireless/rsi/rsi_main.h
index e97e6ad..2cb73e7 100644
--- a/drivers/net/wireless/rsi/rsi_main.h
+++ b/drivers/net/wireless/rsi/rsi_main.h
@@ -40,7 +40,7 @@
#define FSM_MAC_INIT_DONE 6
extern u32 rsi_zone_enabled;
-extern void rsi_dbg(u32 zone, const char *fmt, ...);
+extern __printf(2, 3) void rsi_dbg(u32 zone, const char *fmt, ...);
#define RSI_MAX_VIFS 1
#define NUM_EDCA_QUEUES 4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-03-19 0:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-19 0:59 [PATCH] rsi: Add pr_fmt,__printf, fix format & arg mismatch Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox