* [PATCH] wlcore: ignore dummy packet events in PLT mode
@ 2014-04-10 6:50 Luca Coelho
2014-04-10 7:00 ` Luca Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Luca Coelho @ 2014-04-10 6:50 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, arik, yegorslists
From: Luciano Coelho <luca@coelho.fi>
Sometimes the firmware sends a dummy packet event while we are in PLT
mode. This doesn't make sense, it's a firmware bug. Fix this by
ignoring dummy packet events when we're PLT mode.
Reported-by: Yegor Yefremov <yegorslists@googlemail.com>
Reported-by: Arik Nemtsov <arik@wizery.com>
Signed-off-by: Luciano Coelho <luca@coelho.fi>
---
drivers/net/wireless/ti/wlcore/event.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/ti/wlcore/event.c
index 1f9a360..8d5174c 100644
--- a/drivers/net/wireless/ti/wlcore/event.c
+++ b/drivers/net/wireless/ti/wlcore/event.c
@@ -158,6 +158,11 @@ EXPORT_SYMBOL_GPL(wlcore_event_channel_switch);
void wlcore_event_dummy_packet(struct wl1271 *wl)
{
+ if (wl->plt) {
+ wl1271_info(DEBUG_EVENT, "Got DUMMY_PACKET event in PLT mode. FW bug, ignoring.");
+ return;
+ }
+
wl1271_debug(DEBUG_EVENT, "DUMMY_PACKET_ID_EVENT_ID");
wl1271_tx_dummy_packet(wl);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] wlcore: ignore dummy packet events in PLT mode
2014-04-10 6:50 [PATCH] wlcore: ignore dummy packet events in PLT mode Luca Coelho
@ 2014-04-10 7:00 ` Luca Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luca Coelho @ 2014-04-10 7:00 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, arik, yegorslists
On Thu, 2014-04-10 at 09:50 +0300, Luca Coelho wrote:
> From: Luciano Coelho <luca@coelho.fi>
>
> Sometimes the firmware sends a dummy packet event while we are in PLT
> mode. This doesn't make sense, it's a firmware bug. Fix this by
> ignoring dummy packet events when we're PLT mode.
>
> Reported-by: Yegor Yefremov <yegorslists@googlemail.com>
> Reported-by: Arik Nemtsov <arik@wizery.com>
> Signed-off-by: Luciano Coelho <luca@coelho.fi>
> ---
> drivers/net/wireless/ti/wlcore/event.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/ti/wlcore/event.c
> index 1f9a360..8d5174c 100644
> --- a/drivers/net/wireless/ti/wlcore/event.c
> +++ b/drivers/net/wireless/ti/wlcore/event.c
> @@ -158,6 +158,11 @@ EXPORT_SYMBOL_GPL(wlcore_event_channel_switch);
>
> void wlcore_event_dummy_packet(struct wl1271 *wl)
> {
> + if (wl->plt) {
> + wl1271_info(DEBUG_EVENT, "Got DUMMY_PACKET event in PLT mode. FW bug, ignoring.");
Gack! I changed wl1271_debug to wl1271_info and forgot to compile. This
doesn't compile. v2 coming in a sec.
--
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-10 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-10 6:50 [PATCH] wlcore: ignore dummy packet events in PLT mode Luca Coelho
2014-04-10 7:00 ` Luca Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox