Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Janusz Dziedzic <janusz.dziedzic@gmail.com>,
	Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	collen@cozybit.com
Subject: Re: [RFC/RFT] cfg80211: reg: track crda request
Date: Fri, 11 Apr 2014 22:13:46 +0200	[thread overview]
Message-ID: <1397247226.4643.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <294574679.20140411220931@eikelenboom.it>

On Fri, 2014-04-11 at 22:09 +0200, Sander Eikelenboom wrote:

> I would first like to know if Johannes likes this solution or not.

Heh, I guess that's only fair.

> With previous patches from Luis they were blocked after testing and debugging, so let him 
> first speak out if he likes the approach or not.

I think this looks fine. My main complaint with Luis's patches (besides
reportedly breaking some other use cases) was that he was piggy-backing
on some completely unrelated thing to try to recover something. Here we
have an explicit delayed work struct so that seems fine.

And I really like the part where Janusz moves the delayed_work setting
where it belongs - the CRDA call function :)

johannes


  reply	other threads:[~2014-04-11 20:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 12:29 [RFC/RFT] cfg80211: reg: track crda request Janusz Dziedzic
2014-04-11 14:44 ` Sander Eikelenboom
2014-04-11 17:21 ` Sander Eikelenboom
2014-04-11 19:55   ` Janusz Dziedzic
2014-04-11 20:09     ` Sander Eikelenboom
2014-04-11 20:13       ` Johannes Berg [this message]
2014-04-11 20:16         ` Sander Eikelenboom
2014-04-12 18:49     ` Sander Eikelenboom
2014-04-14 19:58       ` Colleen T
2014-04-13  9:30 ` Arik Nemtsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397247226.4643.8.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=collen@cozybit.com \
    --cc=janusz.dziedzic@gmail.com \
    --cc=janusz.dziedzic@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=mcgrof@do-not-panic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox