* [PATCH] mac80211: fixup radiotap tx flags for RTS/CTS
@ 2014-04-16 12:32 Bob Copeland
2014-04-22 15:08 ` Johannes Berg
2014-04-22 15:09 ` Johannes Berg
0 siblings, 2 replies; 3+ messages in thread
From: Bob Copeland @ 2014-04-16 12:32 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, larrymaxwell, Bob Copeland, Bob Copeland
When using RTS/CTS, the CTS-to-Self bit in radiotap TX flags is
getting set instead of the RTS bit. Set the correct one.
Reported-by: Larry Maxwell <larrymaxwell@agilemesh.com>
Signed-off-by: Bob Copeland <bob@cozybit.com>
---
net/mac80211/status.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index e6e574a..ea432ca 100644
--- a/net/mac80211/status.c
+++ b/net/mac80211/status.c
@@ -314,10 +314,9 @@ ieee80211_add_tx_radiotap_header(struct ieee80211_local *local,
!is_multicast_ether_addr(hdr->addr1))
txflags |= IEEE80211_RADIOTAP_F_TX_FAIL;
- if ((info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS) ||
- (info->status.rates[0].flags & IEEE80211_TX_RC_USE_CTS_PROTECT))
+ if (info->status.rates[0].flags & IEEE80211_TX_RC_USE_CTS_PROTECT)
txflags |= IEEE80211_RADIOTAP_F_TX_CTS;
- else if (info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS)
+ if (info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS)
txflags |= IEEE80211_RADIOTAP_F_TX_RTS;
put_unaligned_le16(txflags, pos);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: fixup radiotap tx flags for RTS/CTS
2014-04-16 12:32 [PATCH] mac80211: fixup radiotap tx flags for RTS/CTS Bob Copeland
@ 2014-04-22 15:08 ` Johannes Berg
2014-04-22 15:09 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2014-04-22 15:08 UTC (permalink / raw)
To: Bob Copeland; +Cc: linux-wireless, larrymaxwell, Bob Copeland
On Wed, 2014-04-16 at 08:32 -0400, Bob Copeland wrote:
> When using RTS/CTS, the CTS-to-Self bit in radiotap TX flags is
> getting set instead of the RTS bit. Set the correct one.
Good catch, applied.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: fixup radiotap tx flags for RTS/CTS
2014-04-16 12:32 [PATCH] mac80211: fixup radiotap tx flags for RTS/CTS Bob Copeland
2014-04-22 15:08 ` Johannes Berg
@ 2014-04-22 15:09 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2014-04-22 15:09 UTC (permalink / raw)
To: Bob Copeland; +Cc: linux-wireless, larrymaxwell, Bob Copeland
On Wed, 2014-04-16 at 08:32 -0400, Bob Copeland wrote:
> When using RTS/CTS, the CTS-to-Self bit in radiotap TX flags is
> getting set instead of the RTS bit. Set the correct one.
Note that the whole TX flags field hasn't been standardised in radiotap
yet - somebody should probably take that up. :)
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-22 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-16 12:32 [PATCH] mac80211: fixup radiotap tx flags for RTS/CTS Bob Copeland
2014-04-22 15:08 ` Johannes Berg
2014-04-22 15:09 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox