RE: [PATCH rtw-next 0/5] wifi: rtw88: pci: Support an older design, like RTL8821AE/RTL8812AE

[Ping-Ke Shih <pkshih@realtek.com>]

Ping-Ke Shih <pkshih@realtek.com> wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> > On 27/10/2026 03:52, Ping-Ke Shih wrote:
> > > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> > >> This series extends rtw88_pci to support an older design, like
> > >> RTL8821AE, RTL8812AE, RTL8723BE, etc.
> > >
> > > The older design is own-bit ring, and the new is read/write index ring
> > > with buffer descriptor. Can we use 'own-bit' instead of 'old' as the file
> > > name ?
> > >
> >
> > Sure, the file name is not a problem. What about the code? All the functions
> > in pci_old.c are prefixed with "rtw_pci_old", and there is rtw_pci_gen_old
> > and rtw_pci_gen_new. Should I rename all of these?
> 
> I'd prefer having consistent suffix as file name, but I have no good idea
> for the suffix. Maybe, '_ob' means 'own-bit ring'?

Or just '_v0', or '_gen0'?

Think a bit more. Maybe, 'old' is still meaningful for generation of PCI
architecture, since Realtek WiFi PCIE chip has only two kinds of architecture.
If there is third one in the future, that must not be added to rtw88.

At first glance of 'old' days ago, I just want to avoid the implicit naming.