From: Paul Bolle <pebolle@tiscali.nl>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Joe Perches <joe@perches.com>,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
sameo@linux.intel.com, clement.perrochaud@effinnov.com,
charles.gorand@effinnov.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, rupran@einserver.de,
stefan.hengelein@fau.de
Subject: Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG
Date: Wed, 29 Apr 2015 10:27:26 +0200 [thread overview]
Message-ID: <1430296046.2411.100.camel@x220> (raw)
In-Reply-To: <1430212127-5841-1-git-send-email-valentinrothberg@gmail.com>
[Added Joe.]
On Tue, 2015-04-28 at 11:08 +0200, Valentin Rothberg wrote:
> The CPP identifier 'DEBUG' is not used in the source code of nfc at all,
> so we can safely remove setting it in both Makefiles.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
> I detected this issue with ./scripts/checkkconfigsymbols.py since
> CONFIG_NFC_DEBUG is not defined in Kconfig.
The patch should be fine, as there is no NFC_DEBUG Kconfig symbol, but
I'm not sure whether the commit explanation is correct.
As it turns out I submitted a very similar patch two years ago (see
https://lkml.kernel.org/r/1365179481.1830.69.camel@x61.thuisdomein ).
And it was pointed out to me that the DEBUG macro is used by the
pr_debug() macro and friends. I already forgot the details but, in
short, DEBUG is a bit of a gotcha: you can't say whether or not it's
used by just grepping for it.
> ---
> drivers/nfc/Makefile | 2 --
> drivers/nfc/nxp-nci/Makefile | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile
> index a4292d790f9b..13b648baf175 100644
> --- a/drivers/nfc/Makefile
> +++ b/drivers/nfc/Makefile
> @@ -14,5 +14,3 @@ obj-$(CONFIG_NFC_TRF7970A) += trf7970a.o
> obj-$(CONFIG_NFC_ST21NFCA) += st21nfca/
> obj-$(CONFIG_NFC_ST21NFCB) += st21nfcb/
> obj-$(CONFIG_NFC_NXP_NCI) += nxp-nci/
> -
> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
> diff --git a/drivers/nfc/nxp-nci/Makefile b/drivers/nfc/nxp-nci/Makefile
> index c008be30bb18..c9ec7869dbd2 100644
> --- a/drivers/nfc/nxp-nci/Makefile
> +++ b/drivers/nfc/nxp-nci/Makefile
> @@ -7,5 +7,3 @@ nxp-nci_i2c-objs = i2c.o
>
> obj-$(CONFIG_NFC_NXP_NCI) += nxp-nci.o
> obj-$(CONFIG_NFC_NXP_NCI_I2C) += nxp-nci_i2c.o
> -
> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-04-29 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:08 [PATCH] drivers/nfc: remove obsolete setting of DEBUG Valentin Rothberg
2015-04-29 8:27 ` Paul Bolle [this message]
2015-04-29 8:45 ` Valentin Rothberg
2015-04-29 8:58 ` Paul Bolle
2015-06-08 21:26 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430296046.2411.100.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=aloisio.almeida@openbossa.org \
--cc=charles.gorand@effinnov.com \
--cc=clement.perrochaud@effinnov.com \
--cc=joe@perches.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rupran@einserver.de \
--cc=sameo@linux.intel.com \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox