From: Paul Bolle <pebolle@tiscali.nl>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Joe Perches <joe@perches.com>,
lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org,
sameo@linux.intel.com, clement.perrochaud@effinnov.com,
charles.gorand@effinnov.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andreas Ruprecht <rupran@einserver.de>,
hengelein Stefan <stefan.hengelein@fau.de>
Subject: Re: [PATCH] drivers/nfc: remove obsolete setting of DEBUG
Date: Wed, 29 Apr 2015 10:58:51 +0200 [thread overview]
Message-ID: <1430297931.2411.110.camel@x220> (raw)
In-Reply-To: <CAD3Xx4KtKfh+RwicZ1P1acYAMgvGALMuoTWZTKMks2qQrRrc4Q@mail.gmail.com>
On Wed, 2015-04-29 at 10:45 +0200, Valentin Rothberg wrote:
> Thanks, I was not aware of it at all. I read the code and it seems
> that if neither DYNAMIC_DEBUG nor DEBUG is defined, pr_debug() does
> nothing more than to return 0.
>
> I am not sure what to do in this case. Somehow it seems reasonable to
> me to add NFC_DEBUG to Kconfig since a considerable amount of code in
> nfc seems to depend on DEBUG.
A few greps tell me the first pointless reference to CONFIG_NFC_DEBUG
was added in v3.1. So clearly the people actually building and using the
nfc code don't need the DEBUG flag. Apparently using pr_debug() by
setting CONFIG_DYNAMIC_DEBUG works for them. (I trust Joe will shout
when that statement is incorrect.)
So, as I said, the patch should be fine, and only the commit explanation
needs work.
Paul Bolle
next prev parent reply other threads:[~2015-04-29 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 9:08 [PATCH] drivers/nfc: remove obsolete setting of DEBUG Valentin Rothberg
2015-04-29 8:27 ` Paul Bolle
2015-04-29 8:45 ` Valentin Rothberg
2015-04-29 8:58 ` Paul Bolle [this message]
2015-06-08 21:26 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430297931.2411.110.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=aloisio.almeida@openbossa.org \
--cc=charles.gorand@effinnov.com \
--cc=clement.perrochaud@effinnov.com \
--cc=joe@perches.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rupran@einserver.de \
--cc=sameo@linux.intel.com \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox