* Cannot disable transmission retry
@ 2015-06-02 16:29 Hodaszi, Robert
2015-06-03 7:54 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Hodaszi, Robert @ 2015-06-02 16:29 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org
SGVsbG8sDQoNCk9uIGtlcm5lbCAzLjEzLCBJIHdhcyBhYmxlIHRvIGRpc2FibGUgdGhlIHRyYW5z
bWlzc2lvbiByZXRyaWVzIG9uIHRoZQ0Kd2xhbjAgaW50ZXJmYWNlIHdpdGggJ2l3Y29uZmlnIHds
YW4wIHJldHJ5IDAnLiBOb3cgSSB1cGRhdGVkIG15IGtlcm5lbA0KdG8gMy4xNiwgYW5kIGl0IHJl
dHVybnMgd2l0aCAnSW52YWxpZCBhcmd1bWVudCcgZXJyb3IuDQoNClRoZSBjYXVzZSBpcyB0aGlz
IGNvbW1pdDoNCg0KY2ZnODAyMTE6IGFkZCBzYW5pdHkgY2hlY2sgZm9yIHJldHJ5IGxpbWl0IGlu
IHdleHQtY29tcGF0DQpodHRwOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0
L3RvcnZhbGRzL2xpbnV4LmdpdC9jb21taXQvP2lkPWY1YWEwZDIxZGQ1YWRhMDQwZmY0MmI0ZDQw
MzU3Mjg1ZTRhY2U0NDENCg0KDQotLS0gYS9uZXQvd2lyZWxlc3Mvd2V4dC1jb21wYXQuYw0KKysr
IGIvbmV0L3dpcmVsZXNzL3dleHQtY29tcGF0LmMNCkBAIC0zNzAsNyArMzcwLDcgQEAgc3RhdGlj
IGludCBjZmc4MDIxMV93ZXh0X3Npd3JldHJ5KHN0cnVjdCBuZXRfZGV2aWNlDQoqZGV2LA0KdTgg
b3Nob3J0ID0gd2Rldi0+d2lwaHktPnJldHJ5X3Nob3J0Ow0KaW50IGVycjsNCg0KLSBpZiAocmV0
cnktPmRpc2FibGVkIHx8DQorIGlmIChyZXRyeS0+ZGlzYWJsZWQgfHwgcmV0cnktPnZhbHVlIDwg
MSB8fCByZXRyeS0+dmFsdWUgPiAyNTUgfHwNCihyZXRyeS0+ZmxhZ3MgJiBJV19SRVRSWV9UWVBF
KSAhPSBJV19SRVRSWV9MSU1JVCkNCnJldHVybiAtRUlOVkFMOw0KDQoNCg0KSSdtIHdvbmRlcmlu
ZywgaXMgdGhlICdyZXRyeS0+dmFsdWUgPCAxJyBpcyBuZWNlc3Nhcnk/IEkgd291bGQgd3JpdGUN
CidyZXRyeS0+dmFsdWUgPCAwJyBpbnN0ZWFkLCB0byBtYWtlIHBvc3NpYmxlIHRvIGRpc2FibGUg
dGhlIHJldHJpZXMuDQpTaG91bGQgSSBzZW5kIGEgcGF0Y2g/DQoNClRoYW5rcyENCg0KUm9iZXJ0
IEhvZGFzemkNCg==
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Cannot disable transmission retry
2015-06-02 16:29 Cannot disable transmission retry Hodaszi, Robert
@ 2015-06-03 7:54 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2015-06-03 7:54 UTC (permalink / raw)
To: Hodaszi, Robert; +Cc: linux-wireless@vger.kernel.org, Ujjal Roy
+patch author
> - if (retry->disabled ||
> + if (retry->disabled || retry->value < 1 || retry->value > 255 ||
> (retry->flags & IW_RETRY_TYPE) != IW_RETRY_LIMIT)
> return -EINVAL;
>
>
>
> I'm wondering, is the 'retry->value < 1' is necessary? I would write
> 'retry->value < 0' instead, to make possible to disable the retries.
> Should I send a patch?
I think this is likely some confusion over what "retry" means. Some
places in the code used to take it as "# of transmission attempts",
others (imho more correctly) interpret it as "# of retries".
I think it's probably fine to change to < 0.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-03 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-02 16:29 Cannot disable transmission retry Hodaszi, Robert
2015-06-03 7:54 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox