[PATCH] brcmfmac: of: Include "of.h" header file

[PATCH] brcmfmac: of: Include "of.h" header file

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Include "of.h" header file to fix the following sparse warning:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Resending to linux-wireless@vger.kernel.org

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
index 03f35e0..6231b36 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
@@ -23,6 +23,7 @@
 #include <defs.h>
 #include "debug.h"
 #include "sdio.h"
+#include "of.h"
 
 void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
 {
-- 
1.9.1

Re: [PATCH] brcmfmac: of: Include "of.h" header file

[Julian Calaby]

Hi All,

On Mon, Feb 15, 2016 at 8:57 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Include "of.h" header file to fix the following sparse warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Looks correct to me.

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] brcmfmac: of: Include "of.h" header file

[Arend Van Spriel]

On Sun, Feb 14, 2016 at 10:57 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Include "of.h" header file to fix the following sparse warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?

Acked-by: Arend van Spriel <arend@broadcom.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Resending to linux-wireless@vger.kernel.org
>
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> index 03f35e0..6231b36 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> @@ -23,6 +23,7 @@
>  #include <defs.h>
>  #include "debug.h"
>  #include "sdio.h"
> +#include "of.h"
>
>  void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
>  {
> --
> 1.9.1
>

Re: [PATCH] brcmfmac: of: Include "of.h" header file

[Arend Van Spriel]

I am actually preparing a patch series and found that this change is
incorporated in that series. As that involves other changes it is
probably better to drop this patch. I thought I could change the
patchwork state for it, but no luck.

Regards,
Arend

On Mon, Feb 15, 2016 at 10:15 AM, Arend Van Spriel
<arend.van@broadcom.com> wrote:
> On Sun, Feb 14, 2016 at 10:57 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> Include "of.h" header file to fix the following sparse warning:
>>
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c:27:6: warning: symbol 'brcmf_of_probe' was not declared. Should it be static?
>
> Acked-by: Arend van Spriel <arend@broadcom.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>> ---
>> Resending to linux-wireless@vger.kernel.org
>>
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> index 03f35e0..6231b36 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> @@ -23,6 +23,7 @@
>>  #include <defs.h>
>>  #include "debug.h"
>>  #include "sdio.h"
>> +#include "of.h"
>>
>>  void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev)
>>  {
>> --
>> 1.9.1
>>

Re: [PATCH] brcmfmac: of: Include "of.h" header file

[Kalle Valo]

Arend Van Spriel <arend.van@broadcom.com> writes:

> I am actually preparing a patch series and found that this change is
> incorporated in that series. As that involves other changes it is
> probably better to drop this patch. I thought I could change the
> patchwork state for it, but no luck.

I think you can only change states of patches which you have submitted.
But I dropped this now.

-- 
Kalle Valo