* [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface
@ 2016-08-11 5:44 Wright Feng
2016-08-19 15:53 ` Rafał Miłecki
0 siblings, 1 reply; 4+ messages in thread
From: Wright Feng @ 2016-08-11 5:44 UTC (permalink / raw)
To: brcm80211-dev-list.pdl, arend.vanspriel, kvalo, franky.lin,
hante.meuleman, pieterpg, linux-wireless, chln
Cc: Wright Feng
When stopping hostap on virtual interface, driver will set INFRA and AP
mode that may affect the functionality on primary interface. For example,
if we create and stop hostapd on virtual interface then association
cannot work on primary interface because INFRA mode has been set to IBSS.
Hence we shut down AP and set IBSS mode only on primary interface.
Signed-off-by: Wright Feng <wright.feng@cypress.com>
---
V2:Remove the footnote from the mail.
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 2628d5e..0687ab9 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -4716,6 +4716,8 @@ exit:
static int brcmf_cfg80211_stop_ap(struct wiphy *wiphy, struct net_device *ndev)
{
+ struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
+ struct net_device *primary_ndev = cfg_to_ndev(cfg);
struct brcmf_if *ifp = netdev_priv(ndev);
s32 err;
struct brcmf_fil_bss_enable_le bss_enable;
@@ -4723,7 +4725,8 @@ static int brcmf_cfg80211_stop_ap(struct wiphy *wiphy, struct net_device *ndev)
brcmf_dbg(TRACE, "Enter\n");
- if (ifp->vif->wdev.iftype == NL80211_IFTYPE_AP) {
+ if ((ifp->vif->wdev.iftype == NL80211_IFTYPE_AP) &&
+ (ndev == primary_ndev)) {
/* Due to most likely deauths outstanding we sleep */
/* first to make sure they get processed by fw. */
msleep(400);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface
2016-08-11 5:44 [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface Wright Feng
@ 2016-08-19 15:53 ` Rafał Miłecki
2016-08-22 3:40 ` Wright Feng
0 siblings, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2016-08-19 15:53 UTC (permalink / raw)
To: Wright Feng
Cc: open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Arend Van Spriel, Kalle Valo, Franky Lin, Hante Meuleman,
Pieter-Paul Giesberts, linux-wireless@vger.kernel.org, chln
On 11 August 2016 at 07:44, Wright Feng <wright.feng@cypress.com> wrote:
> When stopping hostap on virtual interface, driver will set INFRA and AP
> mode that may affect the functionality on primary interface. For example,
> if we create and stop hostapd on virtual interface then association
> cannot work on primary interface because INFRA mode has been set to IBSS.
> Hence we shut down AP and set IBSS mode only on primary interface.
You also excluded from execution code setting BRCMF_C_SET_AP to 0.
Does it get a reset at some point? Maybe with a "bss" call? I'm
wondering if it's possible to use interface in managed mode if it was
used as AP once.
--=20
Rafa=C5=82
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface
2016-08-19 15:53 ` Rafał Miłecki
@ 2016-08-22 3:40 ` Wright Feng
2016-08-23 11:44 ` Rafał Miłecki
0 siblings, 1 reply; 4+ messages in thread
From: Wright Feng @ 2016-08-22 3:40 UTC (permalink / raw)
To: Rafał Miłecki
Cc: open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Arend Van Spriel, Kalle Valo, Franky Lin, Hante Meuleman,
Pieter-Paul Giesberts, linux-wireless@vger.kernel.org,
Chi-Hsien Lin
DQoNCg0KRnJvbTogUmFmYcWCIE1pxYJlY2tpIFttYWlsdG86emFqZWM1QGdtYWlsLmNvbV0NCj4g
T24gMTEgQXVndXN0IDIwMTYgYXQgMDc6NDQsIFdyaWdodCBGZW5nIDx3cmlnaHQuZmVuZ0BjeXBy
ZXNzLmNvbT4gd3JvdGU6DQo+ID4gV2hlbiBzdG9wcGluZyBob3N0YXAgb24gdmlydHVhbCBpbnRl
cmZhY2UsIGRyaXZlciB3aWxsIHNldCBJTkZSQSBhbmQNCj4gPiBBUCBtb2RlIHRoYXQgbWF5IGFm
ZmVjdCB0aGUgZnVuY3Rpb25hbGl0eSBvbiBwcmltYXJ5IGludGVyZmFjZS4gRm9yDQo+ID4gZXhh
bXBsZSwgaWYgd2UgY3JlYXRlIGFuZCBzdG9wIGhvc3RhcGQgb24gdmlydHVhbCBpbnRlcmZhY2Ug
dGhlbg0KPiA+IGFzc29jaWF0aW9uIGNhbm5vdCB3b3JrIG9uIHByaW1hcnkgaW50ZXJmYWNlIGJl
Y2F1c2UgSU5GUkEgbW9kZSBoYXMNCj4gYmVlbiBzZXQgdG8gSUJTUy4NCj4gPiBIZW5jZSB3ZSBz
aHV0IGRvd24gQVAgYW5kIHNldCBJQlNTIG1vZGUgb25seSBvbiBwcmltYXJ5IGludGVyZmFjZS4N
Cj4NCj4gWW91IGFsc28gZXhjbHVkZWQgZnJvbSBleGVjdXRpb24gY29kZSBzZXR0aW5nIEJSQ01G
X0NfU0VUX0FQIHRvIDAuDQo+IERvZXMgaXQgZ2V0IGEgcmVzZXQgYXQgc29tZSBwb2ludD8gTWF5
YmUgd2l0aCBhICJic3MiIGNhbGw/IEknbSB3b25kZXJpbmcgaWYNCj4gaXQncyBwb3NzaWJsZSB0
byB1c2UgaW50ZXJmYWNlIGluIG1hbmFnZWQgbW9kZSBpZiBpdCB3YXMgdXNlZCBhcyBBUCBvbmNl
Lg0KSW4gdGhpcyBjYXNlLCB0aGUgdmlydHVhbCBpbnRlcmZhY2UgY2Fubm90IGJlIG1hbmFnZWQg
bW9kZSB1bmxlc3MgcmUtY3JlYXRpbmcgdGhlIGludGVyZmFjZS4NCkRyaXZlciBzaG91bGQganVz
dCBleGNsdWRlIGZyb20gc2V0dGluZyBJTkZSQSBtb2RlIHdoZW4gc3RvcHBpbmcgQVAgd2l0aCB2
aXJ0dWFsIGludGVyZmFjZSwgYW5kIEknbGwgdXBkYXRlIHRoaXMgY2hhbmdlIGluIFBBVENIIHYz
Lg0KVGhhbmtzIGZvciB5b3VyIHJldmlldy4NCj4NCj4gLS0NCj4gUmFmYcWCDQoNClJlZ2FyZHMs
DQpXcmlnaHQNCg0KVGhpcyBtZXNzYWdlIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4g
Q3lwcmVzcyAob3IgaXRzIHN1YnNpZGlhcmllcykgY29uZmlkZW50aWFsIGluZm9ybWF0aW9uLiBJ
ZiBpdCBoYXMgYmVlbiByZWNlaXZlZCBpbiBlcnJvciwgcGxlYXNlIGFkdmlzZSB0aGUgc2VuZGVy
IGFuZCBpbW1lZGlhdGVseSBkZWxldGUgdGhpcyBtZXNzYWdlLg0K
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface
2016-08-22 3:40 ` Wright Feng
@ 2016-08-23 11:44 ` Rafał Miłecki
0 siblings, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2016-08-23 11:44 UTC (permalink / raw)
To: Wright Feng
Cc: open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
Arend Van Spriel, Kalle Valo, Franky Lin, Hante Meuleman,
Pieter-Paul Giesberts, linux-wireless@vger.kernel.org,
Chi-Hsien Lin
On 22 August 2016 at 05:40, Wright Feng <wefe@cypress.com> wrote:
> This message and any attachments may contain Cypress (or its subsidiaries=
) confidential information. If it has been received in error, please advise=
the sender and immediately delete this message.
You are aware you're writing to few open mailing lists, aren't you? I
don't think such footer makes any/much sense, please avoid it.
--=20
Rafa=C5=82
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-23 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-11 5:44 [PATCH v2] brcmfmac: shut down AP and set IBSS mode only on primary interface Wright Feng
2016-08-19 15:53 ` Rafał Miłecki
2016-08-22 3:40 ` Wright Feng
2016-08-23 11:44 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox